diff mbox series

[RESEND,5/5] input: iqs269a: Make sliders two-dimensional

Message ID 1600289400-27632-6-git-send-email-jeff@labundy.com
State New
Headers show
Series input: iqs269a: Add support for slider gestures and OTP variants | expand

Commit Message

Jeff LaBundy Sept. 16, 2020, 8:50 p.m. UTC
libinput rejects devices that define one axis without the orthogonal
axis, as well as devices for which either axis's resolution is zero.

To solve this problem, present a thin y-axis with a resolution equal
to one.

Signed-off-by: Jeff LaBundy <jeff@labundy.com>
---
 drivers/input/misc/iqs269a.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Dmitry Torokhov Sept. 17, 2020, 12:03 a.m. UTC | #1
On Wed, Sep 16, 2020 at 03:50:00PM -0500, Jeff LaBundy wrote:
> libinput rejects devices that define one axis without the orthogonal
> axis, as well as devices for which either axis's resolution is zero.
> 
> To solve this problem, present a thin y-axis with a resolution equal
> to one.

No, let's fix this in libinput please.

> 
> Signed-off-by: Jeff LaBundy <jeff@labundy.com>
> ---
>  drivers/input/misc/iqs269a.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/input/misc/iqs269a.c b/drivers/input/misc/iqs269a.c
> index 04947f1..4a0e4ec 100644
> --- a/drivers/input/misc/iqs269a.c
> +++ b/drivers/input/misc/iqs269a.c
> @@ -1377,6 +1377,8 @@ static int iqs269_input_init(struct iqs269_private *iqs269)
>  					     EV_KEY, BTN_TOUCH);
>  			input_set_abs_params(iqs269->slider[i],
>  					     ABS_X, 0, 255, 0, 0);
> +			input_set_abs_params(iqs269->slider[i],
> +					     ABS_Y, 0, 1, 0, 0);
>  		}
>  
>  		error = input_register_device(iqs269->slider[i]);
> -- 
> 2.7.4
> 

Thanks.
diff mbox series

Patch

diff --git a/drivers/input/misc/iqs269a.c b/drivers/input/misc/iqs269a.c
index 04947f1..4a0e4ec 100644
--- a/drivers/input/misc/iqs269a.c
+++ b/drivers/input/misc/iqs269a.c
@@ -1377,6 +1377,8 @@  static int iqs269_input_init(struct iqs269_private *iqs269)
 					     EV_KEY, BTN_TOUCH);
 			input_set_abs_params(iqs269->slider[i],
 					     ABS_X, 0, 255, 0, 0);
+			input_set_abs_params(iqs269->slider[i],
+					     ABS_Y, 0, 1, 0, 0);
 		}
 
 		error = input_register_device(iqs269->slider[i]);