| Message ID | 1622545518-18949-1-git-send-email-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Jiri Kosina |
| Headers | show |
| Series | HID: usbhid: hid-pidff: Fix missing error code in hid_pidff_init() | expand |
On Tue, 1 Jun 2021, Jiapeng Chong wrote: > The error code is missing in this code scenario, add the error code > '-EINVAL' to the return value 'error'. > > Eliminate the follow smatch warning: > > drivers/hid/usbhid/hid-pidff.c:1297 hid_pidff_init() warn: missing error > code 'error'. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> This has already been fixed in hid.git via 3dd653c077efd. Thanks,
diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c index ea126c5..731b49e 100644 --- a/drivers/hid/usbhid/hid-pidff.c +++ b/drivers/hid/usbhid/hid-pidff.c @@ -1294,6 +1294,7 @@ int hid_pidff_init(struct hid_device *hid) pidff->pool[PID_DEVICE_MANAGED_POOL].value[0] == 0) { hid_notice(hid, "device does not support device managed pool\n"); + error = -EINVAL; goto fail; }
The error code is missing in this code scenario, add the error code '-EINVAL' to the return value 'error'. Eliminate the follow smatch warning: drivers/hid/usbhid/hid-pidff.c:1297 hid_pidff_init() warn: missing error code 'error'. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- drivers/hid/usbhid/hid-pidff.c | 1 + 1 file changed, 1 insertion(+)