| Message ID | 1636013269-3433050-1-git-send-email-jiasheng@iscas.ac.cn (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Jiri Kosina |
| Headers | show |
| Series | HID: ite: Add parse before start | expand |
Hi Jiasheng, On Thu, Nov 4, 2021 at 9:08 AM Jiasheng Jiang <jiasheng@iscas.ac.cn> wrote: > > It might be better to add hid_parse() before > wacom_parse_and_register() to ask for the report descriptor. seems like a copy/paste error when working on 2 different drivers. > > Fixes: 3c785a0 ("HID: ite: Replace ABS_MISC 120/121 events with touchpad on/off keypresses") > Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> > --- > drivers/hid/hid-ite.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/hid/hid-ite.c b/drivers/hid/hid-ite.c > index 14fc068..3c56f75 100644 > --- a/drivers/hid/hid-ite.c > +++ b/drivers/hid/hid-ite.c > @@ -100,6 +100,10 @@ static int ite_probe(struct hid_device *hdev, const struct hid_device_id *id) > if (ret) > return ret; > > + ret = hid_parse(hdev); hid_parse() is an inline definition of hid_open_report() which is called just above. So here you are asking to call the same code twice, which is suboptimal. Cheers, Benjamin > + if (ret) > + return ret; > + > return hid_hw_start(hdev, HID_CONNECT_DEFAULT); > } > > -- > 2.7.4 >
diff --git a/drivers/hid/hid-ite.c b/drivers/hid/hid-ite.c index 14fc068..3c56f75 100644 --- a/drivers/hid/hid-ite.c +++ b/drivers/hid/hid-ite.c @@ -100,6 +100,10 @@ static int ite_probe(struct hid_device *hdev, const struct hid_device_id *id) if (ret) return ret; + ret = hid_parse(hdev); + if (ret) + return ret; + return hid_hw_start(hdev, HID_CONNECT_DEFAULT); }
It might be better to add hid_parse() before wacom_parse_and_register() to ask for the report descriptor. Fixes: 3c785a0 ("HID: ite: Replace ABS_MISC 120/121 events with touchpad on/off keypresses") Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> --- drivers/hid/hid-ite.c | 4 ++++ 1 file changed, 4 insertions(+)