diff mbox

2.6.31-0.1-default-07068-g43c1266 lockdep warning and scheduling while atomic BUG

Message ID 200909212204.50047.oliver@neukum.org
State New, archived
Headers show

Commit Message

Oliver Neukum Sept. 21, 2009, 8:04 p.m. UTC
Am Montag, 21. September 2009 21:53:28 schrieb Henk Martijn:
> This is a i7 based DELL and current git throws the following warning and
> bug at me during boot:

Please try this patch

	Regards
		Oliver

--

commit ca5c4a1397d1a1c0d1074f4d8922630fdd732780
Author: Oliver Neukum <oliver@neukum.org>
Date:   Mon Sep 21 22:02:01 2009 +0200

    hid:usbhid: fix wrong use of GFP_KERNEL
    
    hid_input_report() must be told it is called in interrupt context


--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Henk Martijn Sept. 21, 2009, 8:17 p.m. UTC | #1
Yes that worked, Thanks!

/Henk

Oliver Neukum wrote:
> Am Montag, 21. September 2009 21:53:28 schrieb Henk Martijn:
>> This is a i7 based DELL and current git throws the following warning and
>> bug at me during boot:
> 
> Please try this patch
> 
> 	Regards
> 		Oliver
> 
> --
> 
> commit ca5c4a1397d1a1c0d1074f4d8922630fdd732780
> Author: Oliver Neukum <oliver@neukum.org>
> Date:   Mon Sep 21 22:02:01 2009 +0200
> 
>     hid:usbhid: fix wrong use of GFP_KERNEL
>     
>     hid_input_report() must be told it is called in interrupt context
> 
> diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c
> index 1b0e07a..ab2869d 100644
> --- a/drivers/hid/usbhid/hid-core.c
> +++ b/drivers/hid/usbhid/hid-core.c
> @@ -455,7 +455,7 @@ static void hid_ctrl(struct urb *urb)
>  		if (usbhid->ctrl[usbhid->ctrltail].dir == USB_DIR_IN)
>  			hid_input_report(urb->context,
>  				usbhid->ctrl[usbhid->ctrltail].report->type,
> -				urb->transfer_buffer, urb->actual_length, 0);
> +				urb->transfer_buffer, urb->actual_length, 1);
>  		break;
>  	case -ESHUTDOWN:	/* unplug */
>  		unplug = 1;
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c
index 1b0e07a..ab2869d 100644
--- a/drivers/hid/usbhid/hid-core.c
+++ b/drivers/hid/usbhid/hid-core.c
@@ -455,7 +455,7 @@  static void hid_ctrl(struct urb *urb)
 		if (usbhid->ctrl[usbhid->ctrltail].dir == USB_DIR_IN)
 			hid_input_report(urb->context,
 				usbhid->ctrl[usbhid->ctrltail].report->type,
-				urb->transfer_buffer, urb->actual_length, 0);
+				urb->transfer_buffer, urb->actual_length, 1);
 		break;
 	case -ESHUTDOWN:	/* unplug */
 		unplug = 1;