From patchwork Mon Sep 21 20:25:48 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oliver Neukum X-Patchwork-Id: 49121 X-Patchwork-Delegate: jikos@jikos.cz Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n8LKOGI3015588 for ; Mon, 21 Sep 2009 20:24:17 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753587AbZIUUYI (ORCPT ); Mon, 21 Sep 2009 16:24:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752456AbZIUUYI (ORCPT ); Mon, 21 Sep 2009 16:24:08 -0400 Received: from smtp-out003.kontent.com ([81.88.40.217]:46548 "EHLO smtp-out003.kontent.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751468AbZIUUYI (ORCPT ); Mon, 21 Sep 2009 16:24:08 -0400 Received: from linux-d698.localnet (p549A21F6.dip0.t-ipconnect.de [84.154.33.246]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: neukum_org@smtp-out003.kontent.com) by smtp-out003.kontent.com (Postfix) with ESMTPSA id 1770E400035F; Mon, 21 Sep 2009 22:24:11 +0200 (CEST) From: Oliver Neukum To: Henk Martijn , linux-input@vger.kernel.org, linux-usb@vger.kernel.org, Greg KH , Jiri Kosina Subject: [patch]fix usbhid using GFP_KERNEL in interrupt Date: Mon, 21 Sep 2009 22:25:48 +0200 User-Agent: KMail/1.10.3 (Linux/2.6.31-rc9-0.1-default; KDE/4.1.3; x86_64; ; ) MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200909212225.48513.oliver@neukum.org> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org hid:usbhid: fix wrong use of GFP_KERNEL hid_input_report() must be told it is called in interrupt context Signed-off-by: Oliver Neukum Hi Jiri, Greg, this should go into the current tree and the stable tree. Regards Oliver --- commit ca5c4a1397d1a1c0d1074f4d8922630fdd732780 Author: Oliver Neukum Date: Mon Sep 21 22:02:01 2009 +0200 hid:usbhid: fix wrong use of GFP_KERNEL hid_input_report() must be told it is called in interrupt context -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c index 1b0e07a..ab2869d 100644 --- a/drivers/hid/usbhid/hid-core.c +++ b/drivers/hid/usbhid/hid-core.c @@ -455,7 +455,7 @@ static void hid_ctrl(struct urb *urb) if (usbhid->ctrl[usbhid->ctrltail].dir == USB_DIR_IN) hid_input_report(urb->context, usbhid->ctrl[usbhid->ctrltail].report->type, - urb->transfer_buffer, urb->actual_length, 0); + urb->transfer_buffer, urb->actual_length, 1); break; case -ESHUTDOWN: /* unplug */ unplug = 1;