From patchwork Tue Nov 10 22:59:38 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ben Dooks X-Patchwork-Id: 59205 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id nAAN058q003084 for ; Tue, 10 Nov 2009 23:00:05 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758454AbZKJW77 (ORCPT ); Tue, 10 Nov 2009 17:59:59 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758634AbZKJW76 (ORCPT ); Tue, 10 Nov 2009 17:59:58 -0500 Received: from aeryn.fluff.org.uk ([87.194.8.8]:42286 "EHLO kira.home.fluff.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758454AbZKJW75 (ORCPT ); Tue, 10 Nov 2009 17:59:57 -0500 Received: from ben by kira.home.fluff.org with local (Exim 4.69) (envelope-from ) id 1N7zgw-0001bY-84; Tue, 10 Nov 2009 23:00:02 +0000 Message-Id: <20091110230002.096943221@fluff.org.uk> User-Agent: quilt/0.48-1 Date: Tue, 10 Nov 2009 22:59:38 +0000 From: Ben Dooks To: linux-input@vger.kernel.org Cc: Simtec Linux Team Subject: [patch 1/3] gpio_keys: use dev_ macros to report information References: <20091110225937.922379610@fluff.org.uk> Content-Disposition: inline; filename=simtec/ready/gpio-buttons-used-dev-reporting.patch Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Index: b/drivers/input/keyboard/gpio_keys.c =================================================================== --- a/drivers/input/keyboard/gpio_keys.c 2009-11-03 22:17:12.000000000 +0000 +++ b/drivers/input/keyboard/gpio_keys.c 2009-11-03 22:22:45.000000000 +0000 @@ -78,6 +78,7 @@ static int __devinit gpio_keys_probe(str { struct gpio_keys_platform_data *pdata = pdev->dev.platform_data; struct gpio_keys_drvdata *ddata; + struct device *dev = &pdev->dev; struct input_dev *input; int i, error; int wakeup = 0; @@ -87,6 +88,7 @@ static int __devinit gpio_keys_probe(str GFP_KERNEL); input = input_allocate_device(); if (!ddata || !input) { + dev_err(dev, "failed to allocate state\n"); error = -ENOMEM; goto fail1; } @@ -122,14 +124,14 @@ static int __devinit gpio_keys_probe(str error = gpio_request(button->gpio, button->desc ?: "gpio_keys"); if (error < 0) { - pr_err("gpio-keys: failed to request GPIO %d," - " error %d\n", button->gpio, error); + dev_err(dev, "failed to request GPIO %d, error %d\n", + button->gpio, error); goto fail2; } error = gpio_direction_input(button->gpio); if (error < 0) { - pr_err("gpio-keys: failed to configure input" + dev_err(dev, "failed to configure" " direction for GPIO %d, error %d\n", button->gpio, error); gpio_free(button->gpio); @@ -139,8 +141,8 @@ static int __devinit gpio_keys_probe(str irq = gpio_to_irq(button->gpio); if (irq < 0) { error = irq; - pr_err("gpio-keys: Unable to get irq number" - " for GPIO %d, error %d\n", + dev_err(dev, "Unable to get irq number " + "for GPIO %d, error %d\n", button->gpio, error); gpio_free(button->gpio); goto fail2; @@ -152,7 +154,7 @@ static int __devinit gpio_keys_probe(str button->desc ? button->desc : "gpio_keys", bdata); if (error) { - pr_err("gpio-keys: Unable to claim irq %d; error %d\n", + dev_err(dev, "Unable to claim irq %d; error %d\n", irq, error); gpio_free(button->gpio); goto fail2; @@ -166,7 +168,7 @@ static int __devinit gpio_keys_probe(str error = input_register_device(input); if (error) { - pr_err("gpio-keys: Unable to register input device, " + dev_err(dev, "Unable to register input device, " "error: %d\n", error); goto fail2; }