From patchwork Wed Apr 7 18:44:04 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Bruno_Pr=C3=A9mont?= X-Patchwork-Id: 91153 X-Patchwork-Delegate: jikos@jikos.cz Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o37IiCii014478 for ; Wed, 7 Apr 2010 18:44:12 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754709Ab0DGSoL (ORCPT ); Wed, 7 Apr 2010 14:44:11 -0400 Received: from legolas.restena.lu ([158.64.1.34]:58638 "EHLO legolas.restena.lu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753756Ab0DGSoL (ORCPT ); Wed, 7 Apr 2010 14:44:11 -0400 Received: from legolas.restena.lu (localhost [127.0.0.1]) by legolas.restena.lu (Postfix) with ESMTP id 74471AF03E; Wed, 7 Apr 2010 20:44:09 +0200 (CEST) Received: from neptune.home (unknown [158.64.15.115]) by legolas.restena.lu (Postfix) with ESMTP id 20117AF4D9; Wed, 7 Apr 2010 20:44:09 +0200 (CEST) Date: Wed, 7 Apr 2010 20:44:04 +0200 From: Bruno =?UTF-8?B?UHLDqW1vbnQ=?= To: Randy Dunlap Cc: Jiri Kosina , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Andrew Morton , rvinyard@cs.nmsu.edu Subject: Re: [PATCH mmotm] hid-picolcd: depends on LCD_CLASS_DEVICE Message-ID: <20100407204404.5233ba6b@neptune.home> In-Reply-To: <20100406095633.49ec957a.randy.dunlap@oracle.com> References: <201004052336.o35NaeSE015814@imap1.linux-foundation.org> <20100405220414.9d90da83.randy.dunlap@oracle.com> <20100406105635.5384a087@pluto.restena.lu> <20100406082614.79aaf1c5.randy.dunlap@oracle.com> <20100406183535.7de3c628@neptune.home> <20100406095633.49ec957a.randy.dunlap@oracle.com> X-Mailer: Claws Mail 3.7.5 (GTK+ 2.18.6; i686-pc-linux-gnu) Mime-Version: 1.0 X-Virus-Scanned: ClamAV Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Wed, 07 Apr 2010 18:44:14 +0000 (UTC) diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index 782a34e..711c091 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -285,7 +285,7 @@ config HID_PICOLCD_FB bool "Framebuffer support" default !EMBEDDED depends on HID_PICOLCD - depends on HID_PICOLCD=FB || FB=y + select FB select FB_DEFERRED_IO select FB_SYS_FILLRECT select FB_SYS_COPYAREA @@ -299,7 +299,8 @@ config HID_PICOLCD_BACKLIGHT bool "Backlight control" default !EMBEDDED depends on HID_PICOLCD - depends on HID_PICOLCD=BACKLIGHT_CLASS_DEVICE || BACKLIGHT_CLASS_DEVICE=y + select BACKLIGHT_LCD_SUPPORT + select BACKLIGHT_CLASS_DEVICE ---help--- Provide access to PicoLCD's backlight control via backlight class. @@ -308,7 +309,8 @@ config HID_PICOLCD_LCD bool "Contrast control" default !EMBEDDED depends on HID_PICOLCD - depends on HID_PICOLCD=LCD_CLASS_DEVICE || LCD_CLASS_DEVICE=y + select BACKLIGHT_LCD_SUPPORT + select LCD_CLASS_DEVICE ---help--- Provide access to PicoLCD's LCD contrast via lcd class. @@ -316,7 +318,8 @@ config HID_PICOLCD_LEDS bool "GPO via leds class" default !EMBEDDED depends on HID_PICOLCD - depends on HID_PICOLCD=LEDS_CLASS || LEDS_CLASS=y + select NEW_LEDS + select LEDS_CLASS ---help--- Provide access to PicoLCD's GPO pins via leds class.