From patchwork Thu Oct 7 16:36:06 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 238431 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id o97GaG5g013415 for ; Thu, 7 Oct 2010 16:36:16 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751880Ab0JGQgQ (ORCPT ); Thu, 7 Oct 2010 12:36:16 -0400 Received: from mail-pw0-f46.google.com ([209.85.160.46]:62787 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751525Ab0JGQgP (ORCPT ); Thu, 7 Oct 2010 12:36:15 -0400 Received: by pwj5 with SMTP id 5so13308pwj.19 for ; Thu, 07 Oct 2010 09:36:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=stG2uuVdMkTwohqcLIc5Hj0i4UZjR1zpIaySvFo9An0=; b=bfu2xiKhRl72tF2ymLESvMIPqgy7DMGZgBBW35UxbBT+eEImFPBXjOFcKxcnjRId/U 1tOuyq2Qga4UNx9PwD8FlJiAG1K0BUShQiYsgAoSnRhbqrhmRTBZQ2/OYAfjczWrHrNW XyruwlqAu3Phqa7ammZr5trFIBg4g2fcfkLYM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=d5RZPYOFej4KivSb4hytLLBZ7eF33G+QpjSiDkuS8uPStdRHpKz5JcuGa8FDg2NNLf H2YNJ9ucqYhi0xhZYf0+SOzMZ1x1BkjZGaZ36tWaRjCsblLgdOAIn2dyCb45Ju5+BLZB kvLEgq7XLwFwNpg0yHYbz8c6kQioLIHlwof3k= Received: by 10.143.13.7 with SMTP id q7mr834582wfi.62.1286469375313; Thu, 07 Oct 2010 09:36:15 -0700 (PDT) Received: from mailhub.coreip.homeip.net (c-24-6-153-206.hsd1.ca.comcast.net [24.6.153.206]) by mx.google.com with ESMTPS id x33sm2511678wfd.1.2010.10.07.09.36.09 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 07 Oct 2010 09:36:11 -0700 (PDT) Date: Thu, 7 Oct 2010 09:36:06 -0700 From: Dmitry Torokhov To: Dmitry Eremin-Solenikov Cc: linux-input@vger.kernel.org Subject: Re: [PATCH v3] serio: add support for PS2Mult multiplexer protocol Message-ID: <20101007163606.GA24406@core.coreip.homeip.net> References: <1285260285-660-1-git-send-email-dbaryshkov@gmail.com> <20100930062547.GF5260@core.coreip.homeip.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter1.kernel.org [140.211.167.41]); Thu, 07 Oct 2010 16:36:17 +0000 (UTC) diff --git a/drivers/input/serio/ps2mult.c b/drivers/input/serio/ps2mult.c index 3664398..52b58de 100644 --- a/drivers/input/serio/ps2mult.c +++ b/drivers/input/serio/ps2mult.c @@ -144,9 +144,6 @@ static int ps2mult_create_port(struct ps2mult *psm, int i) serio->parent = psm->mx_serio; serio->port_data = &psm->ports[i]; - serio_register_port(serio); - dev_info(&serio->dev, "%s port at %s\n", serio->name, mx_serio->phys); - return 0; } @@ -196,8 +193,12 @@ static int ps2mult_connect(struct serio *serio, struct serio_driver *drv) ps2mult_reset(psm); - for (i = 0; i < PS2MULT_NUM_PORTS; i++) - serio_register_port(psm->ports[i].serio); + for (i = 0; i < PS2MULT_NUM_PORTS; i++) { + struct serio *s = psm->ports[i].serio; + + dev_info(&serio->dev, "%s port at %s\n", s->name, serio->phys); + serio_register_port(s); + } return 0;