From patchwork Wed Jul 20 05:31:08 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 990282 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p6K5X0Cs013005 for ; Wed, 20 Jul 2011 05:33:00 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751594Ab1GTFc7 (ORCPT ); Wed, 20 Jul 2011 01:32:59 -0400 Received: from mail-ww0-f44.google.com ([74.125.82.44]:59964 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751215Ab1GTFc7 (ORCPT ); Wed, 20 Jul 2011 01:32:59 -0400 Received: by mail-ww0-f44.google.com with SMTP id 5so4845198wwe.1 for ; Tue, 19 Jul 2011 22:32:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=1koQlfMwyzVy6Bo+vPuZmYl5AFZMbgViSunWp8s5Nhw=; b=pB2D63RH6NWptNGQrOCi3zKNngx94bXWy7fkCip5oHBYHc3XxoezfQNRJckg0oRD9l RiZiK117y/0NIyV1edg/mG32IlNZnEZ/0e5zQobcQIB18GNN/u6NbktlrUAFCKROQZpT gisJqkZWyh9gbI37ICL1GGZmkka6BKe749894= Received: by 10.227.37.83 with SMTP id w19mr7260295wbd.101.1311139978667; Tue, 19 Jul 2011 22:32:58 -0700 (PDT) Received: from shale.localdomain ([41.202.225.152]) by mx.google.com with ESMTPS id 20sm4897133wbw.2.2011.07.19.22.32.55 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 19 Jul 2011 22:32:58 -0700 (PDT) Date: Wed, 20 Jul 2011 08:31:08 +0300 From: Dan Carpenter To: Chris Hudson Cc: Dmitry Torokhov , linux-input@vger.kernel.org Subject: [patch 2/2] Input: kxtj9: fix locking typo in kxtj9_set_poll() Message-ID: <20110720053108.GE6445@shale.localdomain> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Wed, 20 Jul 2011 05:33:00 +0000 (UTC) According to the comments we want to call mutex_lock() here instead of mutex_unlock(). That makes more sense. Signed-off-by: Dan Carpenter --- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/input/misc/kxtj9.c b/drivers/input/misc/kxtj9.c index 6c96dc3..c456f63 100644 --- a/drivers/input/misc/kxtj9.c +++ b/drivers/input/misc/kxtj9.c @@ -362,7 +362,7 @@ static ssize_t kxtj9_set_poll(struct device *dev, struct device_attribute *attr, return error; /* Lock the device to prevent races with open/close (and itself) */ - mutex_unlock(&input_dev->mutex); + mutex_lock(&input_dev->mutex); disable_irq(client->irq);