From patchwork Thu Aug 30 13:12:04 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1388001 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 35169DF264 for ; Thu, 30 Aug 2012 13:12:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752090Ab2H3NMM (ORCPT ); Thu, 30 Aug 2012 09:12:12 -0400 Received: from mail-ey0-f174.google.com ([209.85.215.174]:45952 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751635Ab2H3NMJ (ORCPT ); Thu, 30 Aug 2012 09:12:09 -0400 Received: by eaac11 with SMTP id c11so545412eaa.19 for ; Thu, 30 Aug 2012 06:12:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent :x-gm-message-state; bh=aWXzJavm3MLTbbr42fPH0GBCXjz6tVYAQBcpCGpsc1s=; b=ExmzlSrBzUGdW7lyAAhrh4VOmSXjibKg1srJk0FINCZ7C/+rjcFONXbEUHrbYJyF/q 3F+Q1Iiq30HI+YL0Jwn7JI5DQHQ09S3jYrZLdBc/Q7BmNHRLsbfwu9liTjTtaR2H21Ts 9T+69NiXekgz4D26wMnTFQ/wDQAd8f0VCRc+0p/6m3z5Hrcd58DOk8gKkzl/Ge05f5e3 zq1mJoGXGLvI+ClslXAFtf9tg7ZFi7aW9RpyAQgJmPc/N7qLp2q4g9RAmhqIgHxkHFVC zI30Y/m6pceXItF1tTVatBnS8e3dpY7olzZANpRU5DzspG2V7CBSlHhd/HIAb8Zpr5s7 YLiA== Received: by 10.14.172.129 with SMTP id t1mr6540663eel.34.1346332327681; Thu, 30 Aug 2012 06:12:07 -0700 (PDT) Received: from gmail.com (cpc1-aztw13-0-0-cust473.18-1.cable.virginmedia.com. [77.102.241.218]) by mx.google.com with ESMTPS id y1sm4893779eel.0.2012.08.30.06.12.06 (version=SSLv3 cipher=OTHER); Thu, 30 Aug 2012 06:12:07 -0700 (PDT) Date: Thu, 30 Aug 2012 14:12:04 +0100 From: Lee Jones To: Dmitry Torokhov Cc: Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, STEricsson_nomadik_linux@list.st.com, linus.walleij@stericsson.com, arnd@arndb.de, broonie@opensource.wolfsonmicro.com, linux-input@vger.kernel.org Subject: Re: [PATCH 8/8] input: ab8500-ponkey: Rely on MFD core to convert IRQs to virtual Message-ID: <20120830131202.GG14145@gmail.com> References: <1344527635-6163-1-git-send-email-lee.jones@linaro.org> <1344527635-6163-9-git-send-email-lee.jones@linaro.org> <20120821092328.GC26899@gmail.com> <20120821164244.GA4672@core.coreip.homeip.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120821164244.GA4672@core.coreip.homeip.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-Gm-Message-State: ALoCoQmaSDH6r5weg8qBFXp8n6nvxYLZoHEx5HLcsE87RX0ah0dOUprtkM8sLjBrwfv+PQcqQf+P Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org > Sorry for the delay. Yes, this shoudl be fine, but since it is > essentially a revert of the original patch it should be pushed in as > such. How's this? Author: Lee Jones Date: Thu Aug 30 14:08:19 2012 +0100 Revert "input: ab8500-ponkey: Create AB8500 domain IRQ mapping" This reverts commit ca3b3faf9bee4dc5df4f10eae2d1e48f7de0a8ad. There was a plan to place ab8500_irq_get_virq() calls in each AB8500 child device prior to requesting an IRQ, but as we're no longer using Device Tree to collect our IRQ numbers, it's actually better to allow the core to do this during device registration time. So the IRQ number we pull from its resource has already been converted to a virtual IRQ. CC: Dmitry Torokhov CC: linux-input@vger.kernel.org Acked-by: Linus Walleij Signed-off-by: Lee Jones Acked-by: Dmitry Torokhov --- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/input/misc/ab8500-ponkey.c b/drivers/input/misc/ab8500-ponkey.c index f06231b..84ec691 100644 --- a/drivers/input/misc/ab8500-ponkey.c +++ b/drivers/input/misc/ab8500-ponkey.c @@ -74,8 +74,8 @@ static int __devinit ab8500_ponkey_probe(struct platform_device *pdev) ponkey->idev = input; ponkey->ab8500 = ab8500; - ponkey->irq_dbf = ab8500_irq_get_virq(ab8500, irq_dbf); - ponkey->irq_dbr = ab8500_irq_get_virq(ab8500, irq_dbr); + ponkey->irq_dbf = irq_dbf; + ponkey->irq_dbr = irq_dbr; input->name = "AB8500 POn(PowerOn) Key"; input->dev.parent = &pdev->dev;