| Message ID | 20120913070410.GA309@polaris.bitmath.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Sep 13, 2012 at 9:04 AM, Henrik Rydberg <rydberg@bitmath.se> wrote: >> > >> > this weeks linux-next seems to bring new and new issues, yay :-)! >> > >> > >> > >> > I have taken a photo, but can't say what can have caused. >> > >> > The issue is reproducible... >> > >> > Immediately, after pressing any key (when X-display-manager (lightdm) >> > >> > and X-greeter are up) my machine panics and is no more usable (cold >> > >> > rough brutal killer restart). >> > >> > Note: Using upstart or systemd does not matter. >> > >> > >> > >> > Any pointer to an area where to dig into or any feedback in general is welcome! >> > >> > >> > >> > Kind Regards, >> > >> > - Sedat - >> > >> > Hey, cool. Thanks for the pointer in the source-code and the call-trace! >> > I had reverted [1], but anyway input folks should look at this. >> > >> > Kind Regards, >> > - Sedat - >> > >> > [1] http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commitdiff;h=b276fc1e875a51e4a9dc3322ed008bf4ae481baf >> >> Henrik, >> >> It looks like your changes are causing the panic. > > Indeed, I have pushed the fix below to next already. Thanks for Sedat, > and sorry for not catching this earlier. :-( > Hi Hendrik, Wow, so fast :-). Stephen, can you apply this to today's linux-next (next-20120913), please? Regards, - Sedat - > Henrik > > -- > > From ccc6557bfd02efdca4d9dfda6cfdfe5a08d0193b Mon Sep 17 00:00:00 2001 > From: Henrik Rydberg <rydberg@euromail.se> > Date: Thu, 13 Sep 2012 08:59:40 +0200 > Subject: [PATCH] Input: Fix oops caused by missing null test > > Found in linux-next on September 12, thanks Sedat. > > Reported-by: Sedat Dilek <sedat.dilek@gmail.com> > Signed-off-by: Henrik Rydberg <rydberg@euromail.se> > --- > drivers/input/input.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/input.c b/drivers/input/input.c > index 5b66b2f..2dff71b 100644 > --- a/drivers/input/input.c > +++ b/drivers/input/input.c > @@ -114,7 +114,7 @@ static unsigned int input_to_handler(struct input_handle *handle, > > if (handler->events) > handler->events(handle, vals, count); > - else > + else if (handler->event) > for (v = vals; v != end; v++) > handler->event(handle, v->type, v->code, v->value); > > -- > 1.7.12 > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Sep 13, 2012 at 10:18 AM, Sedat Dilek <sedat.dilek@gmail.com> wrote: > On Thu, Sep 13, 2012 at 9:04 AM, Henrik Rydberg <rydberg@bitmath.se> wrote: >>> > >> > this weeks linux-next seems to bring new and new issues, yay :-)! >>> > >> > >>> > >> > I have taken a photo, but can't say what can have caused. >>> > >> > The issue is reproducible... >>> > >> > Immediately, after pressing any key (when X-display-manager (lightdm) >>> > >> > and X-greeter are up) my machine panics and is no more usable (cold >>> > >> > rough brutal killer restart). >>> > >> > Note: Using upstart or systemd does not matter. >>> > >> > >>> > >> > Any pointer to an area where to dig into or any feedback in general is welcome! >>> > >> > >>> > >> > Kind Regards, >>> > >> > - Sedat - >>> > >>> > Hey, cool. Thanks for the pointer in the source-code and the call-trace! >>> > I had reverted [1], but anyway input folks should look at this. >>> > >>> > Kind Regards, >>> > - Sedat - >>> > >>> > [1] http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commitdiff;h=b276fc1e875a51e4a9dc3322ed008bf4ae481baf >>> >>> Henrik, >>> >>> It looks like your changes are causing the panic. >> >> Indeed, I have pushed the fix below to next already. Thanks for Sedat, >> and sorry for not catching this earlier. :-( >> > > Hi Hendrik, > > Wow, so fast :-). > > Stephen, can you apply this to today's linux-next (next-20120913), please? > > Regards, > - Sedat - > >> Henrik >> >> -- >> >> From ccc6557bfd02efdca4d9dfda6cfdfe5a08d0193b Mon Sep 17 00:00:00 2001 >> From: Henrik Rydberg <rydberg@euromail.se> >> Date: Thu, 13 Sep 2012 08:59:40 +0200 >> Subject: [PATCH] Input: Fix oops caused by missing null test >> >> Found in linux-next on September 12, thanks Sedat. >> >> Reported-by: Sedat Dilek <sedat.dilek@gmail.com> Tested-by: Sedat Dilek <sedat.dilek@gmail.com> Unfortunately, the fix will be in tomorrow's Linux-Next (next-20120914). - Sedat - [1] https://github.com/rydberg/linux/commit/ccc6557bfd02efdca4d9dfda6cfdfe5a08d0193b >> Signed-off-by: Henrik Rydberg <rydberg@euromail.se> >> --- >> drivers/input/input.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/input/input.c b/drivers/input/input.c >> index 5b66b2f..2dff71b 100644 >> --- a/drivers/input/input.c >> +++ b/drivers/input/input.c >> @@ -114,7 +114,7 @@ static unsigned int input_to_handler(struct input_handle *handle, >> >> if (handler->events) >> handler->events(handle, vals, count); >> - else >> + else if (handler->event) >> for (v = vals; v != end; v++) >> handler->event(handle, v->type, v->code, v->value); >> >> -- >> 1.7.12 >> -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Sedat, On Thu, 13 Sep 2012 10:18:28 +0200 Sedat Dilek <sedat.dilek@gmail.com> wrote: > > Stephen, can you apply this to today's linux-next (next-20120913), please? Sorry, it was just a little too late.
diff --git a/drivers/input/input.c b/drivers/input/input.c index 5b66b2f..2dff71b 100644 --- a/drivers/input/input.c +++ b/drivers/input/input.c @@ -114,7 +114,7 @@ static unsigned int input_to_handler(struct input_handle *handle, if (handler->events) handler->events(handle, vals, count); - else + else if (handler->event) for (v = vals; v != end; v++) handler->event(handle, v->type, v->code, v->value);