diff mbox

input: fix input-mt kernel-doc warning

Message ID 20121108175609.GA11114@polaris.bitmath.org (mailing list archive)
State New, archived
Headers show

Commit Message

Henrik Rydberg Nov. 8, 2012, 5:56 p.m. UTC 
Hi Dmitry,

> > > From: Randy Dunlap <rdunlap@infradead.org>
> > > 
> > > Fix new kernel-doc warning in input-mt.c:
> > > 
> > > Warning(drivers/input/input-mt.c:38): No description found for parameter 'flags'
> > 
> > Thanks for the patch. It seemed reasonable to expand the function
> > documentation a bit as well, hope you are alright with the patch
> > below, Dmitry, care to pick this up for 3.7? Otherwise I can carry it
> > for 3.8.
> 
> Randy, Henrik,
> 
> I'll try getting it in 3.7.

Seems there were more warnings introduced in 3.7-rc1... adding the
patch below seems to fix all of them. I guess you want to merge the
former patch into this one.

Thanks,
Henrik

From 1ba1d5e18057260a3203625eaee22cc94393fda3 Mon Sep 17 00:00:00 2001
From: Henrik Rydberg <rydberg@euromail.se>
Date: Thu, 8 Nov 2012 18:48:22 +0100
Subject: [PATCH] Input: Document new struct members

Fixes kernel-doc warnings for the members added in 3.7-rc1.

Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
---
 include/linux/input.h | 3 +++
 1 file changed, 3 insertions(+)

Comments

Dmitry Torokhov Nov. 14, 2012, 6:05 p.m. UTC | #1 
On Thu, Nov 08, 2012 at 06:56:09PM +0100, Henrik Rydberg wrote:
> Hi Dmitry,
> 
> > > > From: Randy Dunlap <rdunlap@infradead.org>
> > > > 
> > > > Fix new kernel-doc warning in input-mt.c:
> > > > 
> > > > Warning(drivers/input/input-mt.c:38): No description found for parameter 'flags'
> > > 
> > > Thanks for the patch. It seemed reasonable to expand the function
> > > documentation a bit as well, hope you are alright with the patch
> > > below, Dmitry, care to pick this up for 3.7? Otherwise I can carry it
> > > for 3.8.
> > 
> > Randy, Henrik,
> > 
> > I'll try getting it in 3.7.
> 
> Seems there were more warnings introduced in 3.7-rc1... adding the
> patch below seems to fix all of them. I guess you want to merge the
> former patch into this one.

Ended up on putting all in 3.8 queue as it clashed with some other data
members I added to struct inptu_dev.

Thanks.
diff mbox

Patch

diff --git a/include/linux/input.h b/include/linux/input.h
index cab994b..2d55e55 100644
--- a/include/linux/input.h
+++ b/include/linux/input.h
@@ -112,6 +112,9 @@  struct input_value {
  * @h_list: list of input handles associated with the device. When
  *	accessing the list dev->mutex must be held
  * @node: used to place the device onto input_dev_list
+ * @num_vals: number of values queued in the current frame
+ * @max_vals: maximum number of values queued in a frame
+ * @vals: array of values queued in the current frame
  */
 struct input_dev {
 	const char *name;