From patchwork Fri May 31 06:29:44 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Hutterer X-Patchwork-Id: 2640541 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id E961DDFB79 for ; Fri, 31 May 2013 06:59:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751207Ab3EaG7t (ORCPT ); Fri, 31 May 2013 02:59:49 -0400 Received: from leo.clearchain.com ([199.73.29.74]:60540 "EHLO mail.clearchain.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751161Ab3EaG7s (ORCPT ); Fri, 31 May 2013 02:59:48 -0400 X-Greylist: delayed 1800 seconds by postgrey-1.27 at vger.kernel.org; Fri, 31 May 2013 02:59:47 EDT Received: from leo.clearchain.com (localhost [127.0.0.1]) by mail.clearchain.com (8.14.5/8.14.5) with ESMTP id r4V6Thfb050917 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 31 May 2013 15:59:43 +0930 (CST) (envelope-from peter.hutterer@who-t.net) Received: (from whot@localhost) by leo.clearchain.com (8.14.5/8.14.5/Submit) id r4V6Tg5R050916; Fri, 31 May 2013 15:59:42 +0930 (CST) (envelope-from peter.hutterer@who-t.net) X-Authentication-Warning: leo.clearchain.com: whot set sender to peter.hutterer@who-t.net using -f Date: Fri, 31 May 2013 16:29:44 +1000 From: Peter Hutterer To: Henrik Rydberg Cc: linux-input@vger.kernel.org, Benjamin Tissoires Subject: [PATCH] doc: specify that ABS_MT_SLOT must have a minimum of 0 Message-ID: <20130531062944.GA915@yabbi.redhat.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-Greylist: Sender is SPF-compliant, not delayed by milter-greylist-4.0.1 (mail.clearchain.com [127.0.0.1]); Fri, 31 May 2013 15:59:43 +0930 (CST) Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org This is effectively already in force through input_mt_init_slots, and uinput too ignores the actual minimum. Since slots are a kernel-genenerated axis only, non-zero minimums make little sense and are likely to cause errors. Better to treat a non-zero minimum as kernel bug if it ever happens. Signed-off-by: Peter Hutterer Acked-by: Benjamin Tissoires --- I admit that sentence looks a bit lost there, if you want to move this elsewhere to have more exposure I'm happy to do so once I figure out where. Documentation/input/multi-touch-protocol.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/input/multi-touch-protocol.txt b/Documentation/input/multi-touch-protocol.txt index 2c17961..de139b1 100644 --- a/Documentation/input/multi-touch-protocol.txt +++ b/Documentation/input/multi-touch-protocol.txt @@ -80,6 +80,8 @@ Userspace can detect that a driver can report more total contacts than slots by noting that the largest supported BTN_TOOL_*TAP event is larger than the total number of type B slots reported in the absinfo for the ABS_MT_SLOT axis. +The minimum value of the ABS_MT_SLOT axis must be 0. + Protocol Example A ------------------