From patchwork Tue Jun 4 21:19:30 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Kaehlcke X-Patchwork-Id: 2662101 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 6B7E9DF2A1 for ; Tue, 4 Jun 2013 21:19:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751616Ab3FDVTg (ORCPT ); Tue, 4 Jun 2013 17:19:36 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:58676 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751272Ab3FDVTf (ORCPT ); Tue, 4 Jun 2013 17:19:35 -0400 Received: from mfilter6-d.gandi.net (mfilter6-d.gandi.net [217.70.178.135]) by relay3-d.mail.gandi.net (Postfix) with ESMTP id E6E6EA80C4; Tue, 4 Jun 2013 23:19:33 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mfilter6-d.gandi.net Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by mfilter6-d.gandi.net (mfilter6-d.gandi.net [10.0.15.180]) (amavisd-new, port 10024) with ESMTP id qPcudiM3Dsna; Tue, 4 Jun 2013 23:19:32 +0200 (CEST) X-Originating-IP: 83.160.107.163 Received: from r4spi.no-ip.org (a83-160-107-163.adsl.xs4all.nl [83.160.107.163]) (Authenticated sender: matthias@kaehlcke.net) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id EC6F5A80B8; Tue, 4 Jun 2013 23:19:31 +0200 (CEST) Received: by r4spi.no-ip.org (Postfix, from userid 1000) id 82CA924015; Tue, 4 Jun 2013 23:19:30 +0200 (CEST) Date: Tue, 4 Jun 2013 23:19:30 +0200 From: Matthias Kaehlcke To: Javier Martinez Canillas , Dmitry Torokhov Cc: Kevin McNeely , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] cyttsp: Fix swap of mfg_stat and mfg_cmd registers Message-ID: <20130604211930.GF3618@raspi> Mail-Followup-To: Matthias Kaehlcke , Javier Martinez Canillas , Dmitry Torokhov , Kevin McNeely , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org The command and status register in the driver were swapped with respect to the order specified in the datasheet (CY8CTMA140). Confirmed with Cypress that the order in the datasheet is correct. Signed-off-by: Matthias Kaehlcke Acked-by: Javier Martinez Canillas Acked-by: Ferruh Yigit --- drivers/input/touchscreen/cyttsp_core.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/cyttsp_core.h b/drivers/input/touchscreen/cyttsp_core.h index 1aa3c69..f1ebde3 100644 --- a/drivers/input/touchscreen/cyttsp_core.h +++ b/drivers/input/touchscreen/cyttsp_core.h @@ -67,8 +67,8 @@ struct cyttsp_xydata { /* TTSP System Information interface definition */ struct cyttsp_sysinfo_data { u8 hst_mode; - u8 mfg_cmd; u8 mfg_stat; + u8 mfg_cmd; u8 cid[3]; u8 tt_undef1; u8 uid[8];