From patchwork Wed Jan 22 14:48:24 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robin Schroer X-Patchwork-Id: 3523681 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 438C59F2E9 for ; Wed, 22 Jan 2014 14:48:37 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 970E020117 for ; Wed, 22 Jan 2014 14:48:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7F0CF2013D for ; Wed, 22 Jan 2014 14:48:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755233AbaAVOsd (ORCPT ); Wed, 22 Jan 2014 09:48:33 -0500 Received: from mail-ea0-f170.google.com ([209.85.215.170]:46985 "EHLO mail-ea0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754528AbaAVOsc (ORCPT ); Wed, 22 Jan 2014 09:48:32 -0500 Received: by mail-ea0-f170.google.com with SMTP id k10so4648140eaj.15 for ; Wed, 22 Jan 2014 06:48:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=mffFVrRaIdf2BV1FaNcNOkCDPBBIif7SzrftVJwtvuU=; b=mC/RLe9AwaXZjVVhlaBWxI/fMY7TNfK6obSF1OMQUgWgKJ6eSICUkM4EidoZUygg5y 4GYKlNxwcqjhsvRwPA1ROWxHBnOYOLWzwskn24PfVjVQf+domqcD5anAmatXLP8ZNhxx 83R7QRaksbWAhZvWQgEt0cD27uwwvKqm5JKruejDZpJLuC/DegEzBraDWg+rjHdpLHeo /7iNhOhyTr/gfwpa3HlVnIJszTvInaChtpRVWaWzBRb5RX5QXwUe2PYQMIGrh9z8uoo3 8JbLMOnI4oGAOeiCfe51wcGmhn4r4Elq3xpcY0cKDzadjwnZ/dy/PejXVqTYKX/KNlI/ I4qw== X-Received: by 10.15.91.3 with SMTP id r3mr1980215eez.18.1390402111326; Wed, 22 Jan 2014 06:48:31 -0800 (PST) Received: from hal9k.fritz.box (pC19F0436.dip0.t-ipconnect.de. [193.159.4.54]) by mx.google.com with ESMTPSA id d43sm27921520eeo.12.2014.01.22.06.48.28 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Jan 2014 06:48:30 -0800 (PST) Date: Wed, 22 Jan 2014 15:48:24 +0100 From: Rob Schroer To: Dmitry Torokhov Cc: Joe Perches , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers/hid/wacom: fixed coding style issues Message-ID: <20140122144824.GA15985@hal9k.fritz.box> References: <20140121195153.GA4198@fedora.fritz.box> <20140121200645.GC29615@core.coreip.homeip.net> <20140121202944.GA4554@fedora.fritz.box> <20140121211823.GD29615@core.coreip.homeip.net> <1390339554.31946.6.camel@joe-AO722> <20140121224203.GA12427@fedora.fritz.box> <20140122064045.GA4143@core.coreip.homeip.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20140122064045.GA4143@core.coreip.homeip.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, Jan 21, 2014 at 10:40:45PM -0800, Dmitry Torokhov wrote: > I think this should be > > error = kstrtoint(buf, 10, &new_speed); > if (error) > return error; > I just lost my SSD/branch, so here is a fresh patch for mainline: Fixed some coding style issues, removed unessecary spaces, added linebreaks, converted an occurence of sscanf to kstrtoint. Signed-off-by: Robin Schroer --- drivers/hid/hid-wacom.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) -- 1.8.4.2 -- Robin -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/hid/hid-wacom.c b/drivers/hid/hid-wacom.c index 60c75dc..c7f9d1c 100644 --- a/drivers/hid/hid-wacom.c +++ b/drivers/hid/hid-wacom.c @@ -77,8 +77,8 @@ static void wacom_scramble(__u8 *image) __u16 mask; __u16 s1; __u16 s2; - __u16 r1 ; - __u16 r2 ; + __u16 r1; + __u16 r2; __u16 r; __u8 buf[256]; int i, w, x, y, z; @@ -336,7 +336,8 @@ static void wacom_set_features(struct hid_device *hdev, u8 speed) switch (hdev->product) { case USB_DEVICE_ID_WACOM_GRAPHIRE_BLUETOOTH: - rep_data[0] = 0x03 ; rep_data[1] = 0x00; + rep_data[0] = 0x03; + rep_data[1] = 0x00; limit = 3; do { ret = hdev->hid_output_raw_report(hdev, rep_data, 2, @@ -403,9 +404,11 @@ static ssize_t wacom_store_speed(struct device *dev, { struct hid_device *hdev = container_of(dev, struct hid_device, dev); int new_speed; + int error; - if (sscanf(buf, "%1d", &new_speed ) != 1) - return -EINVAL; + error = kstrtoint(buf, 10, &new_speed); + if (error) + return error; if (new_speed == 0 || new_speed == 1) { wacom_set_features(hdev, new_speed);