| Message ID | 20140311194253.23daf5e3@endymion.delvare (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Jean, On Tue, Mar 11, 2014 at 07:42:53PM +0100, Jean Delvare wrote: > I don't think the OLPC AP-SP driver is generally useful without OLPC > support. So make it depend on OLPC, unless build testing is enabled. > > Signed-off-by: Jean Delvare <jdelvare@suse.de> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> > --- > drivers/input/serio/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-3.14-rc6.orig/drivers/input/serio/Kconfig 2014-02-09 16:53:02.931633818 +0100 > +++ linux-3.14-rc6/drivers/input/serio/Kconfig 2014-03-11 18:52:42.280541110 +0100 > @@ -263,7 +263,7 @@ config SERIO_APBPS2 > > config SERIO_OLPC_APSP > tristate "OLPC AP-SP input support" > - depends on OF > + depends on OLPC || (OF && COMPILE_TEST) Actually for compile coverage we do not actually need OF, I'll make it depends on OLPC || COMPILE_TEST instead. > help > Say Y here if you want support for the keyboard and touchpad included > in the OLPC XO-1.75 and XO-4 laptops. > > Thanks.
Hi Dmitry, On Tue, 11 Mar 2014 23:11:34 -0700, Dmitry Torokhov wrote: > On Tue, Mar 11, 2014 at 07:42:53PM +0100, Jean Delvare wrote: > > I don't think the OLPC AP-SP driver is generally useful without OLPC > > support. So make it depend on OLPC, unless build testing is enabled. > > > > Signed-off-by: Jean Delvare <jdelvare@suse.de> > > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > --- > > drivers/input/serio/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > --- linux-3.14-rc6.orig/drivers/input/serio/Kconfig 2014-02-09 16:53:02.931633818 +0100 > > +++ linux-3.14-rc6/drivers/input/serio/Kconfig 2014-03-11 18:52:42.280541110 +0100 > > @@ -263,7 +263,7 @@ config SERIO_APBPS2 > > > > config SERIO_OLPC_APSP > > tristate "OLPC AP-SP input support" > > - depends on OF > > + depends on OLPC || (OF && COMPILE_TEST) > > Actually for compile coverage we do not actually need OF, I'll make it > > depends on OLPC || COMPILE_TEST > > instead. Ah, you're right. Thanks for spotting it, your solution is easier and cleaner :)
--- linux-3.14-rc6.orig/drivers/input/serio/Kconfig 2014-02-09 16:53:02.931633818 +0100 +++ linux-3.14-rc6/drivers/input/serio/Kconfig 2014-03-11 18:52:42.280541110 +0100 @@ -263,7 +263,7 @@ config SERIO_APBPS2 config SERIO_OLPC_APSP tristate "OLPC AP-SP input support" - depends on OF + depends on OLPC || (OF && COMPILE_TEST) help Say Y here if you want support for the keyboard and touchpad included in the OLPC XO-1.75 and XO-4 laptops.
I don't think the OLPC AP-SP driver is generally useful without OLPC support. So make it depend on OLPC, unless build testing is enabled. Signed-off-by: Jean Delvare <jdelvare@suse.de> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> --- drivers/input/serio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)