From patchwork Fri Oct 24 22:28:43 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 5150201 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 78F579F374 for ; Fri, 24 Oct 2014 22:28:52 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B27A820265 for ; Fri, 24 Oct 2014 22:28:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C3D7B2025B for ; Fri, 24 Oct 2014 22:28:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754838AbaJXW2t (ORCPT ); Fri, 24 Oct 2014 18:28:49 -0400 Received: from mail-pd0-f174.google.com ([209.85.192.174]:37280 "EHLO mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754558AbaJXW2s (ORCPT ); Fri, 24 Oct 2014 18:28:48 -0400 Received: by mail-pd0-f174.google.com with SMTP id p10so2193184pdj.33 for ; Fri, 24 Oct 2014 15:28:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=/O34MNdq/o5YW5mYAuFbqml9Un7+0aGDLsAWpMNVivc=; b=sz73JgdqQnQ0A5s230uEdqaEyu0z93kk0L3wigAzszdaI0bFrZk/gHAXVvbpM7rnU7 uPvlDOErQ3wEOxeXf82K/XDsLLNL5RqRnfGWJ+MqbEKtB+qDSNLaak1LCyy5Ib7fBMM6 0NNlo2Xt0pJHGfPt3AiK9V2x+9h9C8juzqSqmH98sjVVsMnn/Z0mBLcPZgfxTZBvhpvb sb9+s6DYjQQlvuWf+uhOEkkSDqd6Zk3tji5ptFBaAnnR1KZcCIK3VK1MO9VxL0Grn+oz NPoQDe4Bkh2hK4+uXHuBuyy91vDSIP/fYfOtBWC7qwFkclxJ1c5Tx/qp8Xvn/o9H8/rE JVFg== X-Received: by 10.70.43.46 with SMTP id t14mr7504098pdl.57.1414189727916; Fri, 24 Oct 2014 15:28:47 -0700 (PDT) Received: from dtor-ws ([2620:0:1000:1301:6180:13c1:2924:d8b9]) by mx.google.com with ESMTPSA id ml5sm4747655pab.32.2014.10.24.15.28.46 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 24 Oct 2014 15:28:46 -0700 (PDT) Date: Fri, 24 Oct 2014 15:28:43 -0700 From: Dmitry Torokhov To: linux-input@vger.kernel.org Cc: linux-kernel@vger.kernel.org Subject: [PATCH] Input: ims-pcu - fix dead code in ims_pcu_ofn_reg_addr_store() Message-ID: <20141024222843.GA36854@dtor-ws> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Coverity pointed out that at return point error is always 0 so the conditional is not needed. Signed-off-by: Dmitry Torokhov --- drivers/input/misc/ims-pcu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/misc/ims-pcu.c b/drivers/input/misc/ims-pcu.c index 719410f..afed8e2 100644 --- a/drivers/input/misc/ims-pcu.c +++ b/drivers/input/misc/ims-pcu.c @@ -1381,7 +1381,7 @@ static ssize_t ims_pcu_ofn_reg_addr_store(struct device *dev, pcu->ofn_reg_addr = value; mutex_unlock(&pcu->cmd_mutex); - return error ?: count; + return count; } static DEVICE_ATTR(reg_addr, S_IRUGO | S_IWUSR,