From patchwork Wed Nov 19 18:39:21 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 5340261 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id A8459C11AC for ; Wed, 19 Nov 2014 18:40:52 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D43E32021A for ; Wed, 19 Nov 2014 18:40:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1262320219 for ; Wed, 19 Nov 2014 18:40:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756513AbaKSSj2 (ORCPT ); Wed, 19 Nov 2014 13:39:28 -0500 Received: from mail-ig0-f175.google.com ([209.85.213.175]:51851 "EHLO mail-ig0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756465AbaKSSj0 (ORCPT ); Wed, 19 Nov 2014 13:39:26 -0500 Received: by mail-ig0-f175.google.com with SMTP id h15so3449592igd.8 for ; Wed, 19 Nov 2014 10:39:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=MFkd2Rce82xCEtwIb9Yl3e5vEl6MHTGnnw0q0PLilsU=; b=Py7plENPVtaY7842exM2nOmOpT4OKSNNwYR9tcymMNp/ppo1NgN5zZwa7DU7EtA+Fq 1XX6nTjRpTj0OPYs+65yC2E2NrVS7YvmjPi6g6lBS715odnFBJGRbM5QrH91QklhEPvg T0qoPX6udEpdbNkHTorbxOtghziitV6HESt7NCyuiIHUchyx8iCcTrDOOeTicpURymqq FHJlQabVIJITgQKJr23vMSHNsglOvgt2ah7DKgfYYVc8WrD2T4i4zJQfeBYpGLhqZ5ji SdEbyBE2y0XqzT2Ry4gUrTcKg2JYQ5lQD1t3jWMwwU/o7c50tRNdv8jaIQUkSoZ9r4Ct HtWw== X-Received: by 10.50.18.102 with SMTP id v6mr5003759igd.40.1416422365839; Wed, 19 Nov 2014 10:39:25 -0800 (PST) Received: from dtor-ws ([2620:0:1000:1301:e549:e77:60d1:43bb]) by mx.google.com with ESMTPSA id f4sm18972ioe.11.2014.11.19.10.39.23 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 19 Nov 2014 10:39:24 -0800 (PST) Date: Wed, 19 Nov 2014 10:39:21 -0800 From: Dmitry Torokhov To: Marcus Overhagen Cc: Benjamin Tissoires , Ulrik De Bie , Hans de Goede , "linux-kernel@vger.kernel.org" , linux-input , Jiri Kosina Subject: Re: [git pull] Input updates for 3.18-rc4 Message-ID: <20141119183921.GF37989@dtor-ws> References: <20141114222640.GA39748@dtor-ws> <20141119181247.GE37989@dtor-ws> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, Nov 19, 2014 at 07:20:21PM +0100, Marcus Overhagen wrote: > Hi, > > I will try reverting that, but may need until tomorrow or Friday. > > Just now I made a warm reboot from rc3 to rc5 and initially scrolling > behaviour was ok, but after about a minute it went wrong and I got > this: > > [ 179.705362] ------------[ cut here ]------------ > [ 179.705382] WARNING: CPU: 3 PID: 0 at > drivers/input/mouse/elantech.c:433 > elantech_report_trackpoint.isra.5+0x199/0x1b0 [psmouse]() > [ 179.705385] psmouse serio1: elantech: Unexpected trackpoint message Or just this for now: diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c index 3fcb6b3..294f613 100644 --- a/drivers/input/mouse/elantech.c +++ b/drivers/input/mouse/elantech.c @@ -793,7 +793,7 @@ static int elantech_packet_check_v4(struct psmouse *psmouse) unsigned char packet_type = packet[3] & 0x03; bool sanity_check; - if ((packet[3] & 0x0f) == 0x06) + if ((packet[3] & 0x0f) == 0x06 && etd->tp_dev) return PACKET_TRACKPOINT; /*