From patchwork Tue Feb 10 09:29:31 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Pali_Roh=C3=A1r?= X-Patchwork-Id: 5805611 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 5F5969F36A for ; Tue, 10 Feb 2015 09:29:42 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 88B7220120 for ; Tue, 10 Feb 2015 09:29:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A2A252011D for ; Tue, 10 Feb 2015 09:29:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752660AbbBJJ3i (ORCPT ); Tue, 10 Feb 2015 04:29:38 -0500 Received: from mail-wg0-f50.google.com ([74.125.82.50]:36552 "EHLO mail-wg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752371AbbBJJ3f (ORCPT ); Tue, 10 Feb 2015 04:29:35 -0500 Received: by mail-wg0-f50.google.com with SMTP id l2so6013280wgh.9; Tue, 10 Feb 2015 01:29:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:user-agent:mime-version:content-type :content-transfer-encoding:message-id; bh=4NPkkJnWxHknpfcuyP1e9+HoYQSrF+1denw4daWu9tw=; b=yGZe1/2KUVJ0E5hJdTVEXB/chmb17A6fSEJqFac0vp2PJBI++Ga0cs3Yofw2dIk9qC MXP+oD9ezfzlX0SCn0qsvJOBNsC9VOcEO5QtGl5jqmtro/wqAYQIX0fc3r0wMIF+h3DN EcQ0s4XSK2gNmfB4xUWvYi2l1eyEBLlVrk4MVwtlqfuZ3IxirSV2wDstMdquZmsvC56+ CSXjn7R2gIWDoAk8EvlrCvqQGa9ueW3kxw9mwNp6nr3M4exDvAZfqgjauxGjSZaLc+Qo WlN9ZtpbcDzMHFeQjOmNE7GgU2jgY5N1oE9RFdRKrqwJYXBJeVYo1Z0YOt0f8kfTTfR0 P/vA== X-Received: by 10.194.94.164 with SMTP id dd4mr50619179wjb.56.1423560573774; Tue, 10 Feb 2015 01:29:33 -0800 (PST) Received: from pali-latitude.localnet ([2001:718:1e03:a01::1ca]) by mx.google.com with ESMTPSA id pl1sm17957204wic.23.2015.02.10.01.29.32 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 10 Feb 2015 01:29:32 -0800 (PST) From: Pali =?utf-8?q?Roh=C3=A1r?= To: Dmitry Torokhov , Hans de Goede , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Vadim Klishko Subject: Dell ALPS patches for Dell Latitude E5250/5250, E5450/5450, E5550/5550 Date: Tue, 10 Feb 2015 10:29:31 +0100 User-Agent: KMail/1.13.7 (Linux/3.13.0-45-generic; KDE/4.14.2; x86_64; ; ) MIME-Version: 1.0 Message-Id: <201502101029.31708@pali> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, T_TVD_MIME_EPI,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hello, I want to let you know that Dell officially provides modified psmouse/alps.c driver for Ubuntu 14.04 from Dell support webpage: http://www.dell.com/support/home/ga/en/gadhs1/Drivers/DriversDetails?driverId=CGC6T I do not own any of E5250/5250, E5450/5450, E5550/5550 machines, but at least you should know that Dell (or some subcontractor) is modifying linux kernel drivers to work on Dell machines with Ubuntu. I generated diff against upstream linux v3.17-rc1 version. Maybe it can be useful for other people (who do not use Ubuntu and therefore cannot install Dell driver package). Btw, same alps_probe_trackstick_v3() "hack" code is already for rushmore devices in upstream kernel... --- linux-3.17-rc1/drivers/input/mouse/alps.c 2015-02-08 12:30:54.668554221 +0100 +++ houston-15_A10.fish.tar.gz/debs/touchpad-alps-trusty-dkms_1.0_all.deb/usr/src/touchpad-alps-trusty-1.0/alps.c 2014-09-15 11:49:10.000000000 +0200 @@ -24,12 +24,15 @@ #include "psmouse.h" #include "alps.h" +#define ALPS_DRIVER_RELEASE_DATE "2014/08/25" + /* * Definitions for ALPS version 3 and 4 command mode protocol */ #define ALPS_CMD_NIBBLE_10 0x01f2 #define ALPS_REG_BASE_RUSHMORE 0xc2c0 +#define ALPS_REG_BASE_V7 0xc2c0 #define ALPS_REG_BASE_PINNACLE 0x0000 static const struct alps_nibble_commands alps_v3_nibble_commands[] = { @@ -2208,6 +2211,12 @@ static int alps_identify(struct psmouse priv->proto_version = ALPS_PROTO_V7; alps_set_defaults(priv); + /* hack to make addr_command, nibble_command available */ + psmouse->private = priv; + + if (alps_probe_trackstick_v3(psmouse, ALPS_REG_BASE_V7)) + priv->flags &= ~ALPS_DUALPOINT; + return 0; } else if (ec[0] == 0x88 && ec[1] == 0x08) { priv->proto_version = ALPS_PROTO_V3; @@ -2312,6 +2321,8 @@ int alps_init(struct psmouse *psmouse) if (priv->hw_init(psmouse)) goto init_fail; + printk("ALPS driver in use! %s, date:%s \n", __func__, ALPS_DRIVER_RELEASE_DATE); + /* * Undo part of setup done for us by psmouse core since touchpad * is not a relative device.