From patchwork Tue Apr 14 09:59:24 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mika Westerberg X-Patchwork-Id: 6214521 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id D506D9F1C4 for ; Tue, 14 Apr 2015 09:59:32 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0E649202D1 for ; Tue, 14 Apr 2015 09:59:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 06FA3202B4 for ; Tue, 14 Apr 2015 09:59:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753525AbbDNJ73 (ORCPT ); Tue, 14 Apr 2015 05:59:29 -0400 Received: from mga03.intel.com ([134.134.136.65]:52721 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752815AbbDNJ72 (ORCPT ); Tue, 14 Apr 2015 05:59:28 -0400 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP; 14 Apr 2015 02:59:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,575,1422950400"; d="scan'208";a="713350031" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.73]) by orsmga002.jf.intel.com with SMTP; 14 Apr 2015 02:59:25 -0700 Received: by lahna (sSMTP sendmail emulation); Tue, 14 Apr 2015 12:59:24 +0300 Date: Tue, 14 Apr 2015 12:59:24 +0300 From: Mika Westerberg To: Gabriele Mazzotta Cc: Jiri Kosina , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Benjamin Tissoires Subject: Re: Hidden dependency of i2c-hid on GPIOLIB Message-ID: <20150414095924.GB1677@lahna.fi.intel.com> References: <2014782.heKI7XOhuD@xps13> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2014782.heKI7XOhuD@xps13> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, Apr 14, 2015 at 12:55:20AM +0200, Gabriele Mazzotta wrote: > Hi, > > my touchpad stopped working because of a485923efbb8 ("HID: i2c-hid: > Add support for ACPI GPIO interrupts"). It turned out that I need > CONFIG_GPIOLIB. I think this dependency should be made explicit or the > driver should not depend on it. Using GPIOs should be optional. Gpiolib stubs functions out whenever it is not enabled. However, I made a mistake when GPIOs are fed to the driver. If gpiolib is not enabled acpi_dev_add_driver_gpios() returns -ENXIO and prevents your touchpad from working. I think it is alright to ignore the error here. Can you try if below patch helps? --- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c index ab4dd952b6ba..b427c11d4cd3 100644 --- a/drivers/hid/i2c-hid/i2c-hid.c +++ b/drivers/hid/i2c-hid/i2c-hid.c @@ -877,7 +877,8 @@ static int i2c_hid_acpi_pdata(struct i2c_client *client, pdata->hid_descriptor_address = obj->integer.value; ACPI_FREE(obj); - return acpi_dev_add_driver_gpios(adev, i2c_hid_acpi_gpios); + acpi_dev_add_driver_gpios(adev, i2c_hid_acpi_gpios); + return 0; } static const struct acpi_device_id i2c_hid_acpi_match[] = {