diff mbox

[v2,6/6] input: mms114: Fix module autoload for OF platform driver

Message ID 20150829105055.GA20965@goodgumbo.baconseed.org (mailing list archive)
State New, archived
Headers show

Commit Message

Luis de Bethencourt Aug. 29, 2015, 10:50 a.m. UTC
This platform driver has a OF device ID table but the OF module
alias information is not created so module autoloading won't work.

Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>
---

Moving the MODULE_DEVICE_TABLE into the CONFIG_OF #ifdef block.
As suggested by Dmitry Torokhov.

Thanks for the review Dmitry,
Luis

 drivers/input/touchscreen/mms114.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Dmitry Torokhov Sept. 3, 2015, 5:54 p.m. UTC | #1
On Sat, Aug 29, 2015 at 12:50:55PM +0200, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
> 
> Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>

Already have this one as well.

> ---
> 
> Moving the MODULE_DEVICE_TABLE into the CONFIG_OF #ifdef block.
> As suggested by Dmitry Torokhov.
> 
> Thanks for the review Dmitry,
> Luis
> 
>  drivers/input/touchscreen/mms114.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/input/touchscreen/mms114.c b/drivers/input/touchscreen/mms114.c
> index 67c0d31..df778f4 100644
> --- a/drivers/input/touchscreen/mms114.c
> +++ b/drivers/input/touchscreen/mms114.c
> @@ -572,6 +572,7 @@ static const struct of_device_id mms114_dt_match[] = {
>  	{ .compatible = "melfas,mms114" },
>  	{ }
>  };
> +MODULE_DEVICE_TABLE(of, mms114_dt_match);
>  #endif
>  
>  static struct i2c_driver mms114_driver = {
> -- 
> 2.4.6
>
diff mbox

Patch

diff --git a/drivers/input/touchscreen/mms114.c b/drivers/input/touchscreen/mms114.c
index 67c0d31..df778f4 100644
--- a/drivers/input/touchscreen/mms114.c
+++ b/drivers/input/touchscreen/mms114.c
@@ -572,6 +572,7 @@  static const struct of_device_id mms114_dt_match[] = {
 	{ .compatible = "melfas,mms114" },
 	{ }
 };
+MODULE_DEVICE_TABLE(of, mms114_dt_match);
 #endif
 
 static struct i2c_driver mms114_driver = {