From patchwork Mon Jan 4 09:10:34 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Tissoires X-Patchwork-Id: 7946331 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 7C3D4BEEE5 for ; Mon, 4 Jan 2016 09:10:45 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 963F62035E for ; Mon, 4 Jan 2016 09:10:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 63DAB2035D for ; Mon, 4 Jan 2016 09:10:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751473AbcADJKm (ORCPT ); Mon, 4 Jan 2016 04:10:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53767 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753136AbcADJKi (ORCPT ); Mon, 4 Jan 2016 04:10:38 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 9254EA37EF; Mon, 4 Jan 2016 09:10:38 +0000 (UTC) Received: from mail.corp.redhat.com (ovpn-116-26.ams2.redhat.com [10.36.116.26]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u049AYAW031062 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 4 Jan 2016 04:10:37 -0500 Date: Mon, 4 Jan 2016 10:10:34 +0100 From: Benjamin Tissoires To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, Jim lovell Subject: Re: Quanta touchscreen 0408:3003 does not work with hid-multitouch Message-ID: <20160104091034.GA20222@mail.corp.redhat.com> References: <20151219174154.GC27255@dtor-ws> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20151219174154.GC27255@dtor-ws> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Dec 19 2015 or thereabouts, Dmitry Torokhov wrote: > On Tue, Nov 10, 2015 at 10:21:15PM -0600, Jim lovell wrote: > > [1.] 0408:3003 Quanta Computer, Inc. Touchscreen Controller Detected > > But Doesn't Work > > > > [2.] Booting my computer using the newest mainline kernel, the > > built-in USB 0408:3003 Quanta Computer, Inc. touchscreen controller is > > detected but doesn't work. The touchscreen controller is detected but > > no touches are acknowleged. Using "xinput [id] test" no output is > > generated while single or multi touching the screen. > > ... > > > > > [X.] Launchpad Bug Report > > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1514310 > > Workaround that 70% of the time allows single touches to work > > until the system is rebooted. > > xinput set-mode [id] RELATIVE > > xinput set-mode [id] ABSOLUTE > > sudo rmmod hid-multitouch > > sudo modprobe hid-multitouch > > > > xinput --list > > ? Quanta Computer OpticalTouchScreen id=12 [slave pointer (2)] > > lsusb > > Bus 001 Device 005: ID 0408:3003 Quanta Computer, Inc. > > lsmod > > hid 118784 7 hid_multitouch,usbhid,hid_logitech_dj,hid_logitech_hidpp > > dmesg (most recent output after many attempts following elmarikon's "fix") > > input: Quanta Computer OpticalTouchScreen as > > /devices/pci0000:00/0000:00:1a.0/usb1/1-1/1-1.6/1-1.6:1.0/0003:0408:3003.0007/input/input16 > > hid-multitouch 0003:0408:3003.0007: input,hiddev0,hidraw4: USB > > HID v1.10 Mouse [Quanta Computer OpticalTouchScreen] on > > usb-0000:00:1a.0-1.6/input0 > > hid-multitouch 0003:0408:3003.0007: usb_submit_urb(ctrl) failed: -1 > > hid-multitouch 0003:0408:3003.0007: usb_submit_urb(ctrl) failed: -1 > > Benjamin, any ideas? > dmesg shows a lot of: [ 12.304314] hid-multitouch 0003:0408:3003.0007: usb_submit_urb(ctrl) failed: -1 [ 12.304384] hid-multitouch 0003:0408:3003.0007: timeout initializing reports And the other Quanta devices has a quirk NO_GET to work around this. Jim, does the following patch helps: m 729b779256296e68b2079b813ccb61354f8c77d7 Mon Sep 17 00:00:00 2001 From: Benjamin Tissoires Date: Mon, 4 Jan 2016 10:08:54 +0100 Subject: [PATCH] HID: add HID_QUIRK_NOGET to Quanta 3003 too dmesg shows a lot of: [ 1374.890348] hid-multitouch 0003:0408:3003.0007: usb_submit_urb(ctrl) failed: -1 [ 1384.916388] hid-multitouch 0003:0408:3003.0007: usb_submit_urb(ctrl) failed: -1 [ 1384.916432] hid-multitouch 0003:0408:3003.0007: timeout initializing reports Add the quirk and make the touchscreen happy. Signed-off-by: Benjamin Tissoires --- drivers/hid/hid-ids.h | 1 + drivers/hid/usbhid/hid-quirks.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index ac1feea..4561a9e 100644 --- a/drivers/hid/hid-ids.h +++ b/drivers/hid/hid-ids.h @@ -801,6 +801,7 @@ #define USB_VENDOR_ID_QUANTA 0x0408 #define USB_DEVICE_ID_QUANTA_OPTICAL_TOUCH 0x3000 #define USB_DEVICE_ID_QUANTA_OPTICAL_TOUCH_3001 0x3001 +#define USB_DEVICE_ID_QUANTA_OPTICAL_TOUCH_3003 0x3003 #define USB_DEVICE_ID_QUANTA_OPTICAL_TOUCH_3008 0x3008 #define USB_VENDOR_ID_RAZER 0x1532 diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c index 94bb137..8910f79 100644 --- a/drivers/hid/usbhid/hid-quirks.c +++ b/drivers/hid/usbhid/hid-quirks.c @@ -109,6 +109,7 @@ static const struct hid_blacklist { { USB_VENDOR_ID_PRIMAX, USB_DEVICE_ID_PRIMAX_MOUSE_4D22, HID_QUIRK_ALWAYS_POLL }, { USB_VENDOR_ID_PRODIGE, USB_DEVICE_ID_PRODIGE_CORDLESS, HID_QUIRK_NOGET }, { USB_VENDOR_ID_QUANTA, USB_DEVICE_ID_QUANTA_OPTICAL_TOUCH_3001, HID_QUIRK_NOGET }, + { USB_VENDOR_ID_QUANTA, USB_DEVICE_ID_QUANTA_OPTICAL_TOUCH_3003, HID_QUIRK_NOGET }, { USB_VENDOR_ID_QUANTA, USB_DEVICE_ID_QUANTA_OPTICAL_TOUCH_3008, HID_QUIRK_NOGET }, { USB_VENDOR_ID_REALTEK, USB_DEVICE_ID_REALTEK_READER, HID_QUIRK_NO_INIT_REPORTS }, { USB_VENDOR_ID_SENNHEISER, USB_DEVICE_ID_SENNHEISER_BTD500USB, HID_QUIRK_NOGET },