| Message ID | 20160711214954.2668262-1-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Jiri Kosina |
| Headers | show |
On Jul 11 2016 or thereabouts, Arnd Bergmann wrote: > A recent commit added barry support to this driver, but that causes > a link failure when CONFIG_POWER_SUPPLY is not set: > > drivers/hid/built-in.o: In function `hidpp_battery_get_property': > :(.text+0x1a834): undefined reference to `power_supply_get_drvdata' > drivers/hid/built-in.o: In function `hidpp_raw_event': > :(.text+0x1b10c): undefined reference to `power_supply_changed' > drivers/hid/built-in.o: In function `hidpp_connect_event': > :(.text+0x1bd88): undefined reference to `devm_power_supply_register' > :(.text+0x1be30): undefined reference to `power_supply_powers' > > This adds a dependency, identically to the other HID drivers that need this. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Fixes: 5a2b190cddb9 ("HID: logitech-hidpp: add battery support for HID++ 2.0 devices") Thanks for the fix. Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Cheers, Benjamin > --- > drivers/hid/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig > index 78ac4811bd3c..4c6b59c9fa15 100644 > --- a/drivers/hid/Kconfig > +++ b/drivers/hid/Kconfig > @@ -440,6 +440,7 @@ config HID_LOGITECH_DJ > config HID_LOGITECH_HIDPP > tristate "Logitech HID++ devices support" > depends on HID_LOGITECH > + select POWER_SUPPLY > ---help--- > Support for Logitech devices relyingon the HID++ Logitech specification > > -- > 2.9.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 12 Jul 2016, Benjamin Tissoires wrote: > > A recent commit added barry support to this driver, but that causes > > a link failure when CONFIG_POWER_SUPPLY is not set: > > > > drivers/hid/built-in.o: In function `hidpp_battery_get_property': > > :(.text+0x1a834): undefined reference to `power_supply_get_drvdata' > > drivers/hid/built-in.o: In function `hidpp_raw_event': > > :(.text+0x1b10c): undefined reference to `power_supply_changed' > > drivers/hid/built-in.o: In function `hidpp_connect_event': > > :(.text+0x1bd88): undefined reference to `devm_power_supply_register' > > :(.text+0x1be30): undefined reference to `power_supply_powers' > > > > This adds a dependency, identically to the other HID drivers that need this. > > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Fixes: 5a2b190cddb9 ("HID: logitech-hidpp: add battery support for HID++ 2.0 devices") > > Thanks for the fix. > Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Thanks. I am pushing this to for-4.8/logitech-hidpp-battery, but I will be unmerging that branch from 'for-next' shortly anyway, as the whole patchset is currently on hold.
diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index 78ac4811bd3c..4c6b59c9fa15 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -440,6 +440,7 @@ config HID_LOGITECH_DJ config HID_LOGITECH_HIDPP tristate "Logitech HID++ devices support" depends on HID_LOGITECH + select POWER_SUPPLY ---help--- Support for Logitech devices relyingon the HID++ Logitech specification
A recent commit added barry support to this driver, but that causes a link failure when CONFIG_POWER_SUPPLY is not set: drivers/hid/built-in.o: In function `hidpp_battery_get_property': :(.text+0x1a834): undefined reference to `power_supply_get_drvdata' drivers/hid/built-in.o: In function `hidpp_raw_event': :(.text+0x1b10c): undefined reference to `power_supply_changed' drivers/hid/built-in.o: In function `hidpp_connect_event': :(.text+0x1bd88): undefined reference to `devm_power_supply_register' :(.text+0x1be30): undefined reference to `power_supply_powers' This adds a dependency, identically to the other HID drivers that need this. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Fixes: 5a2b190cddb9 ("HID: logitech-hidpp: add battery support for HID++ 2.0 devices") --- drivers/hid/Kconfig | 1 + 1 file changed, 1 insertion(+)