diff mbox

HID: add missing \n to end of dev_warn messages

Message ID 20160927185844.14659-1-colin.king@canonical.com (mailing list archive)
State New, archived
Headers show

Commit Message

Colin King Sept. 27, 2016, 6:58 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

Trival fix, dev_warn messages are missing a \n, so add it.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 include/linux/hid.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Benjamin Tissoires Sept. 28, 2016, 6:39 p.m. UTC | #1 
On Sep 27 2016 or thereabouts, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Trival fix, dev_warn messages are missing a \n, so add it.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

> ---
>  include/linux/hid.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/hid.h b/include/linux/hid.h
> index 75b66ec..b2ec827 100644
> --- a/include/linux/hid.h
> +++ b/include/linux/hid.h
> @@ -837,7 +837,7 @@ __u32 hid_field_extract(const struct hid_device *hid, __u8 *report,
>   */
>  static inline void hid_device_io_start(struct hid_device *hid) {
>  	if (hid->io_started) {
> -		dev_warn(&hid->dev, "io already started");
> +		dev_warn(&hid->dev, "io already started\n");
>  		return;
>  	}
>  	hid->io_started = true;
> @@ -857,7 +857,7 @@ static inline void hid_device_io_start(struct hid_device *hid) {
>   */
>  static inline void hid_device_io_stop(struct hid_device *hid) {
>  	if (!hid->io_started) {
> -		dev_warn(&hid->dev, "io already stopped");
> +		dev_warn(&hid->dev, "io already stopped\n");
>  		return;
>  	}
>  	hid->io_started = false;
> -- 
> 2.9.3
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/include/linux/hid.h b/include/linux/hid.h
index 75b66ec..b2ec827 100644
--- a/include/linux/hid.h
+++ b/include/linux/hid.h
@@ -837,7 +837,7 @@  __u32 hid_field_extract(const struct hid_device *hid, __u8 *report,
  */
 static inline void hid_device_io_start(struct hid_device *hid) {
 	if (hid->io_started) {
-		dev_warn(&hid->dev, "io already started");
+		dev_warn(&hid->dev, "io already started\n");
 		return;
 	}
 	hid->io_started = true;
@@ -857,7 +857,7 @@  static inline void hid_device_io_start(struct hid_device *hid) {
  */
 static inline void hid_device_io_stop(struct hid_device *hid) {
 	if (!hid->io_started) {
-		dev_warn(&hid->dev, "io already stopped");
+		dev_warn(&hid->dev, "io already stopped\n");
 		return;
 	}
 	hid->io_started = false;