From patchwork Mon Oct 3 08:56:52 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 9360271 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 657CA607D8 for ; Mon, 3 Oct 2016 08:57:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5931528938 for ; Mon, 3 Oct 2016 08:57:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4DCE628957; Mon, 3 Oct 2016 08:57:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EADB228938 for ; Mon, 3 Oct 2016 08:57:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752520AbcJCI45 (ORCPT ); Mon, 3 Oct 2016 04:56:57 -0400 Received: from mx2.suse.de ([195.135.220.15]:60009 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751365AbcJCI4z (ORCPT ); Mon, 3 Oct 2016 04:56:55 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id A38F3ABFC; Mon, 3 Oct 2016 08:56:53 +0000 (UTC) From: Jiri Slaby To: dmitry.torokhov@gmail.com Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Jiri Slaby Subject: [PATCH -resend] Input: i8042, lower log level when controller_init fails Date: Mon, 3 Oct 2016 10:56:52 +0200 Message-Id: <20161003085652.15810-1-jslaby@suse.cz> X-Mailer: git-send-email 2.10.0 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There are a lot of machines without i8042 controller nowadays. Sometimes i8042_controller_check returns 0 because i8042_flush does nothing (read from the port returns 0 and the while loop does not execute). In that case, the probe method is called and fails with this error output to console: i8042: Can't read CTR while initializing i8042 i8042: probe of i8042 failed with error -5 Lower the former error message to be KERN_INFO and make the function in that case return -ENODEV instead of -EIO. This will suppress the latter. There is also an IBM support page about these messages: https://www-947.ibm.com/support/entry/portal/docdisplay?lndocid=migr-5082417 Signed-off-by: Jiri Slaby --- drivers/input/serio/i8042.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c index 405252a884dd..15c87b98d70b 100644 --- a/drivers/input/serio/i8042.c +++ b/drivers/input/serio/i8042.c @@ -950,8 +950,8 @@ static int i8042_controller_init(void) udelay(50); if (i8042_command(&ctr[n++ % 2], I8042_CMD_CTL_RCTR)) { - pr_err("Can't read CTR while initializing i8042\n"); - return -EIO; + pr_info("Can't read CTR while initializing i8042. Either i8042 controller is not present or it does not respond.\n"); + return -ENODEV; } } while (n < 2 || ctr[0] != ctr[1]);