From patchwork Fri Dec 9 10:35:20 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 9467817 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0DE2F60586 for ; Fri, 9 Dec 2016 10:35:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 047DA28573 for ; Fri, 9 Dec 2016 10:35:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id ED1F5285B7; Fri, 9 Dec 2016 10:35:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AB69E28573 for ; Fri, 9 Dec 2016 10:35:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932468AbcLIKf1 (ORCPT ); Fri, 9 Dec 2016 05:35:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46144 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932349AbcLIKf1 (ORCPT ); Fri, 9 Dec 2016 05:35:27 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CF85881226; Fri, 9 Dec 2016 10:35:26 +0000 (UTC) Received: from shalem.localdomain.com (vpn1-6-165.ams2.redhat.com [10.36.6.165]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uB9AZNeg008389; Fri, 9 Dec 2016 05:35:25 -0500 From: Hans de Goede To: Dmitry Torokhov Cc: "russianneuromancer @ ya . ru" , Gregor Riepl , linux-input@vger.kernel.org, Hans de Goede Subject: [PATCH 2/4] Input: silead_gsl1680: gpiod_get returning -EBUSY is not an error Date: Fri, 9 Dec 2016 11:35:20 +0100 Message-Id: <20161209103522.3833-2-hdegoede@redhat.com> In-Reply-To: <20161209103522.3833-1-hdegoede@redhat.com> References: <20161209103522.3833-1-hdegoede@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 09 Dec 2016 10:35:26 +0000 (UTC) Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP ACPI gpios may return -EBUSY this means that the gpio is owned by the ACPI code, and will be set / cleared as needed by the ACPI code. Treat gpiod_get returning -EBUSY as not having a gpio, fixing the driver not loading on tablets where this happens. Signed-off-by: Hans de Goede --- drivers/input/touchscreen/silead.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/input/touchscreen/silead.c b/drivers/input/touchscreen/silead.c index f502c84..4387cd8 100644 --- a/drivers/input/touchscreen/silead.c +++ b/drivers/input/touchscreen/silead.c @@ -467,6 +467,14 @@ static int silead_ts_probe(struct i2c_client *client, /* Power GPIO pin */ data->gpio_power = devm_gpiod_get_optional(dev, "power", GPIOD_OUT_LOW); +#ifdef CONFIG_ACPI + /* + * ACPI gpios may return -EBUSY this means that the gpio is owned by + * the ACPI code, and will be set / cleared by the ACPI code. + */ + if (IS_ERR(data->gpio_power) && PTR_ERR(data->gpio_power) == -EBUSY) + data->gpio_power = NULL; +#endif if (IS_ERR(data->gpio_power)) { if (PTR_ERR(data->gpio_power) != -EPROBE_DEFER) dev_err(dev, "Shutdown GPIO request failed\n");