diff mbox

Input: i8042-x86ia64io.h - Comment else/endif of CONFIG_PNP

Message ID 20161209235518.14465-1-marcos.souza.org@gmail.com (mailing list archive)
State Accepted
Headers show

Commit Message

Marcos Paulo de Souza Dec. 9, 2016, 11:55 p.m. UTC 
As this define check if huge, this makes easier to read the code.

Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
---
 While reviewing patches from Dmitry about presence of 8042, it makes it
 much easier to understand the ifdefs...

 drivers/input/serio/i8042-x86ia64io.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Dmitry Torokhov Dec. 10, 2016, 2 a.m. UTC | #1 
On Fri, Dec 09, 2016 at 09:55:09PM -0200, Marcos Paulo de Souza wrote:
> As this define check if huge, this makes easier to read the code.
> 
> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>

Applied, thank you.

> ---
>  While reviewing patches from Dmitry about presence of 8042, it makes it
>  much easier to understand the ifdefs...
> 
>  drivers/input/serio/i8042-x86ia64io.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/input/serio/i8042-x86ia64io.h b/drivers/input/serio/i8042-x86ia64io.h
> index 073246c..ddd3132 100644
> --- a/drivers/input/serio/i8042-x86ia64io.h
> +++ b/drivers/input/serio/i8042-x86ia64io.h
> @@ -1131,10 +1131,10 @@ static int __init i8042_pnp_init(void)
>  	return 0;
>  }
>  
> -#else
> +#else  /* !CONFIG_PNP */
>  static inline int i8042_pnp_init(void) { return 0; }
>  static inline void i8042_pnp_exit(void) { }
> -#endif
> +#endif /* CONFIG_PNP */
>  
>  static int __init i8042_platform_init(void)
>  {
> -- 
> 2.9.3
>
diff mbox

Patch

diff --git a/drivers/input/serio/i8042-x86ia64io.h b/drivers/input/serio/i8042-x86ia64io.h
index 073246c..ddd3132 100644
--- a/drivers/input/serio/i8042-x86ia64io.h
+++ b/drivers/input/serio/i8042-x86ia64io.h
@@ -1131,10 +1131,10 @@  static int __init i8042_pnp_init(void)
 	return 0;
 }
 
-#else
+#else  /* !CONFIG_PNP */
 static inline int i8042_pnp_init(void) { return 0; }
 static inline void i8042_pnp_exit(void) { }
-#endif
+#endif /* CONFIG_PNP */
 
 static int __init i8042_platform_init(void)
 {