From patchwork Thu Apr 13 23:49:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 9680443 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7E5C160381 for ; Thu, 13 Apr 2017 23:49:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 70576286AC for ; Thu, 13 Apr 2017 23:49:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 63669286AE; Thu, 13 Apr 2017 23:49:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 082B4286AC for ; Thu, 13 Apr 2017 23:49:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752986AbdDMXt2 (ORCPT ); Thu, 13 Apr 2017 19:49:28 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:33041 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752822AbdDMXt1 (ORCPT ); Thu, 13 Apr 2017 19:49:27 -0400 Received: by mail-pg0-f68.google.com with SMTP id 63so987066pgh.0; Thu, 13 Apr 2017 16:49:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=1nK7Dys70hEJVw5BR1ZFhytor8Ae1JIiie3fi+cS0fw=; b=o/G2f8o+sRBHYiHKcjQ8PdHPtWmKLHR6RslYwKt7WzL0RMPaNuH5GZ0+JJWMmz6MSa U85tb+xQTPjv0LjPLfJtYURbXOLasy1UXq2fPVZ6VhkY6LQuwtCfILkFa6b2gsn7i/wt r/iumEvnI9K7/HerZb106G9z8yuvaUEdxwboXAw0gQ78JbFriiyH650anGMiZrpAJ9fo JWhSns+c8sW+XiGWmjElXrDQ7l1qj0YANxRFu+x8tt0s7poVWJRafOhdQjM50BlDkGrm jHJItWyjjnpJ9jWN6as8l9DFrIW1NfdE4nNKvT5iDUpQgf/pUv6UaOAV4mgUX1rCLXD2 QSxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=1nK7Dys70hEJVw5BR1ZFhytor8Ae1JIiie3fi+cS0fw=; b=Mqtp/G/Ux/vZMkm8hdMJAut8dHI2rtCgQSJsg9Y4n+NWX27PTzHOLg57KU5JRVRkvr gsr8wee96085hbJolg7TpAeFVFFU18qbigflM40YQe5+xsPqpZGkJ6q0cDp2DBWvowlf JDKekx3QW8Lb+xAEicHHHqprDyYJeJLpann5DMYxTnSjEuJo/X1Wx13WSq996paELl4r HhUWqosgBDFcvyCpFSE7M1HchJnwRkGKiKsDn7aQFX/0fntCOYQpriU/Qaca4wBw0Q/5 TKglLikcrZzpVZk/emRhimklXZNLOqMuQMmL33wq6jfSTIwDfKLO/k0/AAW8exxlAc0S RX+A== X-Gm-Message-State: AN3rC/4CLq6ii9Z7Tg54DlTjP2PD4iPp+R4g7wNrMVoGhJDaDIXyN5L7 4z0vmBP32jKC9Q== X-Received: by 10.98.166.197 with SMTP id r66mr4405462pfl.5.1492127366639; Thu, 13 Apr 2017 16:49:26 -0700 (PDT) Received: from dtor-ws ([2620:0:1000:1311:91dd:3e36:1236:8882]) by smtp.gmail.com with ESMTPSA id s65sm194042pgb.34.2017.04.13.16.49.25 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 13 Apr 2017 16:49:25 -0700 (PDT) Date: Thu, 13 Apr 2017 16:49:23 -0700 From: Dmitry Torokhov To: linux-input@vger.kernel.org Cc: Martin Kepplinger , Guenter Roeck , Wolfram Sang , Jean Delvare , Christian Gmeiner , linux-kernel@vger.kernel.org Subject: [PATCH] Input: ar1021 - do not force raising edge IRQ trigger Message-ID: <20170413234923.GA38321@dtor-ws> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP We should not be forcing edge triggered interrupt, but rather let platform decide the kind of trigger it needs to use. Also, the driver is not quite safe with regard to edge-triggered interrupts as it does not try to kick the controller after requesting/enabling IRQ. Signed-off-by: Dmitry Torokhov Tested-by: Martin Kepplinger Reviewed-By: Christian Gmeiner Acked-by: Jean Delvare --- drivers/input/touchscreen/ar1021_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/ar1021_i2c.c b/drivers/input/touchscreen/ar1021_i2c.c index 6797e123925a..6c3c79b7ff51 100644 --- a/drivers/input/touchscreen/ar1021_i2c.c +++ b/drivers/input/touchscreen/ar1021_i2c.c @@ -109,7 +109,7 @@ static int ar1021_i2c_probe(struct i2c_client *client, error = devm_request_threaded_irq(&client->dev, client->irq, NULL, ar1021_i2c_irq, - IRQF_TRIGGER_RISING | IRQF_ONESHOT, + IRQF_ONESHOT, "ar1021_i2c", ar1021); if (error) { dev_err(&client->dev,