diff mbox

driver: input :touchscreen : Change Raydium firmware update parameter

Message ID 20170503153717.328-1-jeffrey.lin@rad-ic.com (mailing list archive)
State New, archived
Headers show

Commit Message

jeffrey.lin May 3, 2017, 3:37 p.m. UTC
From: "jeffrey.lin" <jeffrey.lin@raydium.corp-partner.google.com>

Change boot mode trigger parameter of Raydium firmware update.

Signed-off-by: jeffrey.lin <jeffrey.lin@rad-ic.com>
---
 drivers/input/touchscreen/raydium_i2c_ts.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Guenter Roeck May 3, 2017, 3:55 p.m. UTC | #1
On Wed, May 3, 2017 at 8:37 AM, jeffrey.lin <yajohn@gmail.com> wrote:
> From: "jeffrey.lin" <jeffrey.lin@raydium.corp-partner.google.com>
>
> Change boot mode trigger parameter of Raydium firmware update.
>

That is a bit vague. What is changed to what, and why ?

In other words, what prevents someone else from changing it back to
the old value, using the same description ?

> Signed-off-by: jeffrey.lin <jeffrey.lin@rad-ic.com>
> ---
>  drivers/input/touchscreen/raydium_i2c_ts.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/touchscreen/raydium_i2c_ts.c b/drivers/input/touchscreen/raydium_i2c_ts.c
> index a99fb5cac5a0..8a81257634ba 100644
> --- a/drivers/input/touchscreen/raydium_i2c_ts.c
> +++ b/drivers/input/touchscreen/raydium_i2c_ts.c
> @@ -450,7 +450,7 @@ static bool raydium_i2c_boot_trigger(struct i2c_client *client)
>                 { 0x08, 0x04, 0x09, 0x00, 0x50, 0xA5 },
>                 { 0x08, 0x0C, 0x09, 0x00, 0x50, 0x00 },
>                 { 0x06, 0x01, 0x00, 0x00, 0x00, 0x00 },
> -               { 0x02, 0xA2, 0x00, 0x00, 0x00, 0x00 },
> +               { 0x02, 0xA1, 0x00, 0x00, 0x00, 0x00 },
>         };
>         int i;
>         int error;
> @@ -1199,7 +1199,7 @@ static SIMPLE_DEV_PM_OPS(raydium_i2c_pm_ops,
>                          raydium_i2c_suspend, raydium_i2c_resume);
>
>  static const struct i2c_device_id raydium_i2c_id[] = {
> -       { "raydium_i2c" , 0 },
> +       { "raydium_i2c", 0 },

Unrelated whitespace change.

>         { "rm32380", 0 },
>         { /* sentinel */ }
>  };
> --
> 2.12.2
>
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
jeffrey.lin May 4, 2017, 1:43 a.m. UTC | #2
Hi Guenter:
>> Change boot mode trigger parameter of Raydium firmware update.
>>

>That is a bit vague. What is changed to what, and why ?

>In other words, what prevents someone else from changing it back to
>the old value, using the same description ?

This bit control erase type as doing firmware update. We want just reserve more infomation after pass through production line. This's convenient
 for debug, so that it's okay as some one use old version.

>> Signed-off-by: jeffrey.lin <jeffrey.lin@rad-ic.com>
>> ---
>>  drivers/input/touchscreen/raydium_i2c_ts.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/input/touchscreen/raydium_i2c_ts.c b/drivers/input/touchscreen/raydium_i2c_ts.c
>> index a99fb5cac5a0..8a81257634ba 100644
>> --- a/drivers/input/touchscreen/raydium_i2c_ts.c
>> +++ b/drivers/input/touchscreen/raydium_i2c_ts.c
>> @@ -450,7 +450,7 @@ static bool raydium_i2c_boot_trigger(struct i2c_client *client)
>>                 { 0x08, 0x04, 0x09, 0x00, 0x50, 0xA5 },
>>                 { 0x08, 0x0C, 0x09, 0x00, 0x50, 0x00 },
>>                 { 0x06, 0x01, 0x00, 0x00, 0x00, 0x00 },
>> -               { 0x02, 0xA2, 0x00, 0x00, 0x00, 0x00 },
>> +               { 0x02, 0xA1, 0x00, 0x00, 0x00, 0x00 },
>>         };


Thanks.

Jeffrey
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/input/touchscreen/raydium_i2c_ts.c b/drivers/input/touchscreen/raydium_i2c_ts.c
index a99fb5cac5a0..8a81257634ba 100644
--- a/drivers/input/touchscreen/raydium_i2c_ts.c
+++ b/drivers/input/touchscreen/raydium_i2c_ts.c
@@ -450,7 +450,7 @@  static bool raydium_i2c_boot_trigger(struct i2c_client *client)
 		{ 0x08, 0x04, 0x09, 0x00, 0x50, 0xA5 },
 		{ 0x08, 0x0C, 0x09, 0x00, 0x50, 0x00 },
 		{ 0x06, 0x01, 0x00, 0x00, 0x00, 0x00 },
-		{ 0x02, 0xA2, 0x00, 0x00, 0x00, 0x00 },
+		{ 0x02, 0xA1, 0x00, 0x00, 0x00, 0x00 },
 	};
 	int i;
 	int error;
@@ -1199,7 +1199,7 @@  static SIMPLE_DEV_PM_OPS(raydium_i2c_pm_ops,
 			 raydium_i2c_suspend, raydium_i2c_resume);
 
 static const struct i2c_device_id raydium_i2c_id[] = {
-	{ "raydium_i2c" , 0 },
+	{ "raydium_i2c", 0 },
 	{ "rm32380", 0 },
 	{ /* sentinel */ }
 };