From patchwork Mon Oct 23 23:44:47 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 10023327 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8405660245 for ; Mon, 23 Oct 2017 23:45:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6BC2A2891E for ; Mon, 23 Oct 2017 23:45:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5D5EC28923; Mon, 23 Oct 2017 23:45:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F30C82891E for ; Mon, 23 Oct 2017 23:45:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751209AbdJWXo6 (ORCPT ); Mon, 23 Oct 2017 19:44:58 -0400 Received: from mail-io0-f194.google.com ([209.85.223.194]:50006 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751116AbdJWXo6 (ORCPT ); Mon, 23 Oct 2017 19:44:58 -0400 Received: by mail-io0-f194.google.com with SMTP id n137so22016495iod.6; Mon, 23 Oct 2017 16:44:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=AqK8bMuugRTfesz32MrDAdsVquAlxzOBjjR6dpUnkrY=; b=KzvhRJ2IPsxicIYwcp/mRaaBAHN0brxRDB0ilY9CFnjcBptqD/G2vlljt5c0ihbsN2 +gNqu4FXLFpYS1ZGelCHeS8/F0NNpDpI60g+PAxiIuNLgs0lOjhptbH3TUqPfPkA2vKn +9h8PZkNLz0miswqmEPQC7/1THxundLKZabN/crGwqehdbwy9u2k29VSwUGIPjCj1xy6 RutxTKC4KfZ8/cXBLySe1T/evDjq/qBQdZZcq5ilO4WruwTKBMDInq9IAjxcslKVga+/ MkPIEw8isszqOh64JAR1QWLn8SamfnP8bWqpLOINwzDda4p5NXypRbUauNYVg8x+3fST pcXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=AqK8bMuugRTfesz32MrDAdsVquAlxzOBjjR6dpUnkrY=; b=qzF59mT4qi1hnUfbTYxPVFvY1g+ki7iCyjioSR/aQkeWFgCLeqpeLGakktjPhrUfam PXiG3xcWErHfH3yMLCe1iMYDXCYX2KnLM3IjgeIoz8d9u9OR3ysV/DipD412NDdz8Y9Z fbx2OgJ1xfOLaE5juyINA9hDUbl5sF1Z27YeJnrzfjkX/cp3ypYaLSRYobi4zKQi7Rne DX5HTbQOUnFGI/wPREw5jG5uWisHL1UMYknKs9ppY6NJVXG0O+8NcD0jd6jvIC73ddfs n8ndJNtyEA5WeTTGqR/XAnJnU4ExK6Ze7cwfW8sH3ZaY1jWH1fCLm7wVT7j8mTRs0mv5 XtlQ== X-Gm-Message-State: AMCzsaVe0WdEvG2wkA/BPX+fjx8E90DsNPSIjHA7du5ioEM6lwT7OAg6 Wn6l75lBQVF2ktpZZ77yh6M9cJmR X-Google-Smtp-Source: ABhQp+TzwJL65aIODL/lSEO+/HvF3soLAVPfQYIRMwkV4Nh/H5zutJl7dOvxWzUznnVDhiP5VG4UZQ== X-Received: by 10.107.152.67 with SMTP id a64mr17884892ioe.168.1508802296807; Mon, 23 Oct 2017 16:44:56 -0700 (PDT) Received: from dtor-ws ([2620:0:1000:1611:da80:8749:c06f:9515]) by smtp.gmail.com with ESMTPSA id i62sm3646887ioe.31.2017.10.23.16.44.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Oct 2017 16:44:55 -0700 (PDT) Date: Mon, 23 Oct 2017 16:44:47 -0700 From: Dmitry Torokhov To: linux-input@vger.kernel.org Cc: Danilo Krummrich , Linus Walleij , linux-kernel@vger.kernel.org Subject: [PATCH] Input: ps2-gpio - actually abort probe when connected to sleeping GPIOs Message-ID: <20171023234447.qaohcuyfvnwn5m2n@dtor-ws> MIME-Version: 1.0 Content-Disposition: inline User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP We've been missing a goto to the unwind path... Signed-off-by: Dmitry Torokhov --- drivers/input/serio/ps2-gpio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/input/serio/ps2-gpio.c b/drivers/input/serio/ps2-gpio.c index b50e3817f3c4..c62cceb97bb1 100644 --- a/drivers/input/serio/ps2-gpio.c +++ b/drivers/input/serio/ps2-gpio.c @@ -366,6 +366,7 @@ static int ps2_gpio_probe(struct platform_device *pdev) gpiod_cansleep(drvdata->gpio_clk)) { dev_err(dev, "GPIO data or clk are connected via slow bus\n"); error = -EINVAL; + goto err_free_serio; } drvdata->irq = platform_get_irq(pdev, 0);