| Message ID | 20171206165438.676-1-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Dec 6, 2017 at 5:54 PM, Hans de Goede <hdegoede@redhat.com> wrote: > Given all the effort distros have done with splash-screens to give > users a nice clean boot experience, we really want dmesg --level=err > to not print anything unless there is a real problem with either the > hardware or the kernel. Buggy HID descriptors unfortunately happen > all too often, so lower the log level to warning keep the console > clear of error messages such as: > > [ 441.079664] apple 0005:05AC:0239.0003: unknown main item tag 0x0 > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> > drivers/hid/hid-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c > index 7297b1d1300c..c2560aae5542 100644 > --- a/drivers/hid/hid-core.c > +++ b/drivers/hid/hid-core.c > @@ -551,7 +551,7 @@ static int hid_parser_main(struct hid_parser *parser, struct hid_item *item) > ret = hid_add_field(parser, HID_FEATURE_REPORT, data); > break; > default: > - hid_err(parser->device, "unknown main item tag 0x%x\n", item->tag); > + hid_warn(parser->device, "unknown main item tag 0x%x\n", item->tag); > ret = 0; > } > > -- > 2.14.3 > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 6 Dec 2017, Hans de Goede wrote: > Given all the effort distros have done with splash-screens to give > users a nice clean boot experience, we really want dmesg --level=err > to not print anything unless there is a real problem with either the > hardware or the kernel. Buggy HID descriptors unfortunately happen > all too often, so lower the log level to warning keep the console > clear of error messages such as: > > [ 441.079664] apple 0005:05AC:0239.0003: unknown main item tag 0x0 > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > drivers/hid/hid-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c > index 7297b1d1300c..c2560aae5542 100644 > --- a/drivers/hid/hid-core.c > +++ b/drivers/hid/hid-core.c > @@ -551,7 +551,7 @@ static int hid_parser_main(struct hid_parser *parser, struct hid_item *item) > ret = hid_add_field(parser, HID_FEATURE_REPORT, data); > break; > default: > - hid_err(parser->device, "unknown main item tag 0x%x\n", item->tag); > + hid_warn(parser->device, "unknown main item tag 0x%x\n", item->tag); > ret = 0; Applied to for-4.15/upstream-fixes. Thanks,
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index 7297b1d1300c..c2560aae5542 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -551,7 +551,7 @@ static int hid_parser_main(struct hid_parser *parser, struct hid_item *item) ret = hid_add_field(parser, HID_FEATURE_REPORT, data); break; default: - hid_err(parser->device, "unknown main item tag 0x%x\n", item->tag); + hid_warn(parser->device, "unknown main item tag 0x%x\n", item->tag); ret = 0; }
Given all the effort distros have done with splash-screens to give users a nice clean boot experience, we really want dmesg --level=err to not print anything unless there is a real problem with either the hardware or the kernel. Buggy HID descriptors unfortunately happen all too often, so lower the log level to warning keep the console clear of error messages such as: [ 441.079664] apple 0005:05AC:0239.0003: unknown main item tag 0x0 Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/hid/hid-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)