From patchwork Wed Jan 24 19:38:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 10183031 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E40BB602B7 for ; Wed, 24 Jan 2018 19:38:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F05D9209CC for ; Wed, 24 Jan 2018 19:38:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E52672886A; Wed, 24 Jan 2018 19:38:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8AC4F209CC for ; Wed, 24 Jan 2018 19:38:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932319AbeAXTiN (ORCPT ); Wed, 24 Jan 2018 14:38:13 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:34620 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932304AbeAXTiL (ORCPT ); Wed, 24 Jan 2018 14:38:11 -0500 Received: by mail-pf0-f195.google.com with SMTP id e76so3916012pfk.1; Wed, 24 Jan 2018 11:38:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ghB1/6LteFWfokp+OcV/vF1ODJcbMjB1kaMZ5YwU6bc=; b=M2JyLezHRl5RWA6pQpabURjC56e1PSPpkEBIZMKFbT4pc8J85BXlyrPQlcMhdW/NDd g9JZSf+O6mKdGj4cvzHMBvDY99TddVgn058wL3hRqD/d9ft+MDub0s3Pnu6ye8alLHuG NX+DFjFv6I3ojEsqw1Karcu9vSCfRpg8QfaeyRq+FvR8m9bgeobOgKA5jiXGNrWua4Mt fCPCaHzGuILwky3fd2pdR/Qsa6w5FCAOgIwoo1vhXuVS9qiJTpnbJPq6EhYnkakiDYmR u9a7dg8amT8mzOM9yO0i/+okbtAMbm6e8Am7euZygjZnjw9Erygl3gU8vzTuS1aT5IkN i73Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ghB1/6LteFWfokp+OcV/vF1ODJcbMjB1kaMZ5YwU6bc=; b=WYRRGQUV1dVPW8cITq2H74+5AN+LYUTOvCIHPeYxGduz6/9REZ0GK9PCFNSVLYv6kG CDiULTz0q2kKlyDnY8+WkUwH1SfbEPzv2o/Z42ovjgm6cViIgrJc6MA1A980L+/cjhMl sHfIu6Wvq3AazZKpVc53HtotBT7nyWOcW7ctaTm0ATDgYjgcNi250nn3spchN/aJTXjI UsrRlWd0nTnGW9TOSjl1kF3Ke6iqosqmWmhmQSV5mu6RC6zCKnPzbySvD9rCQnliLnZA n6fHo6RQXF2wB8KajmV3BO9twqY7jSEhV69wMKYt4CDIhry6wx1oFOzyNL2SIO/qWgcY jkfA== X-Gm-Message-State: AKwxyten58P5dVZtfxIJSL++XndfGt4ZhTVmG8pR4/zdDzVuVf9R4VrU PA4KpRck13OKDSTLmz52d/Y= X-Google-Smtp-Source: AH8x226lu8wbvHbBewkvSaH2ua8+TZcQ3wTIJ5ODIrOUfaDF4rqwUZv4nKLKiyHmQ8r4HLSrzNcw+w== X-Received: by 10.98.129.194 with SMTP id t185mr13768729pfd.228.1516822690347; Wed, 24 Jan 2018 11:38:10 -0800 (PST) Received: from dtor-ws.mtv.corp.google.com ([2620:0:1000:1611:da80:8749:c06f:9515]) by smtp.gmail.com with ESMTPSA id f188sm11881834pfc.22.2018.01.24.11.38.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Jan 2018 11:38:08 -0800 (PST) From: Dmitry Torokhov To: Simon Shields , Andi Shyti Cc: Rob Herring , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/4] Input: mms114 - do not clobber interrupt trigger Date: Wed, 24 Jan 2018 11:38:01 -0800 Message-Id: <20180124193804.155654-2-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.16.0.rc1.238.g530d649a79-goog In-Reply-To: <20180124193804.155654-1-dmitry.torokhov@gmail.com> References: <20180124193804.155654-1-dmitry.torokhov@gmail.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Rely on the platform (device tree, ACPI, etc) to properly configure interrupt trigger/polarity instead of hardcoding the falling edge. Signed-off-by: Dmitry Torokhov Reviewed-by: Andi Shyti Tested-by: Andi Shyti --- drivers/input/touchscreen/mms114.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/input/touchscreen/mms114.c b/drivers/input/touchscreen/mms114.c index e5eeb6311f7de..92f2e9da351f1 100644 --- a/drivers/input/touchscreen/mms114.c +++ b/drivers/input/touchscreen/mms114.c @@ -497,9 +497,9 @@ static int mms114_probe(struct i2c_client *client, return error; } - error = devm_request_threaded_irq(&client->dev, client->irq, NULL, - mms114_interrupt, IRQF_TRIGGER_FALLING | IRQF_ONESHOT, - dev_name(&client->dev), data); + error = devm_request_threaded_irq(&client->dev, client->irq, + NULL, mms114_interrupt, IRQF_ONESHOT, + dev_name(&client->dev), data); if (error) { dev_err(&client->dev, "Failed to register interrupt\n"); return error;