| Message ID | 20180129113323.18961-6-andi.shyti@samsung.com (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
On Mon, Jan 29, 2018 at 08:33:20PM +0900, Andi Shyti wrote: > Signed-off-by: Andi Shyti <andi.shyti@samsung.com> But why? > --- > drivers/input/touchscreen/mms114.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/input/touchscreen/mms114.c b/drivers/input/touchscreen/mms114.c > index 11dba8bb48e3..fdf23bc416af 100644 > --- a/drivers/input/touchscreen/mms114.c > +++ b/drivers/input/touchscreen/mms114.c > @@ -20,7 +20,7 @@ > > /* Write only registers */ > #define MMS114_MODE_CONTROL 0x01 > -#define MMS114_OPERATION_MODE_MASK 0xE > +#define MMS114_OPERATION_MODE_MASK 0xe > #define MMS114_ACTIVE (1 << 1) > > #define MMS114_XY_RESOLUTION_H 0x02 > @@ -30,12 +30,12 @@ > #define MMS114_MOVING_THRESHOLD 0x06 > > /* Read only registers */ > -#define MMS114_PACKET_SIZE 0x0F > +#define MMS114_PACKET_SIZE 0x0f > #define MMS114_INFOMATION 0x10 > -#define MMS114_TSP_REV 0xF0 > +#define MMS114_TSP_REV 0xf0 > > -#define MMS152_FW_REV 0xE1 > -#define MMS152_COMPAT_GROUP 0xF2 > +#define MMS152_FW_REV 0xe1 > +#define MMS152_COMPAT_GROUP 0xf2 > > /* 200ms needs after power on */ > #define MMS114_POWERON_DELAY 200 > -- > 2.15.1 >
Hi Dmitry, On Mon, Jan 29, 2018 at 10:56:31AM -0800, Dmitry Torokhov wrote: > On Mon, Jan 29, 2018 at 08:33:20PM +0900, Andi Shyti wrote: > > Signed-off-by: Andi Shyti <andi.shyti@samsung.com> > > But why? I think this patch is trivial and the subject itself is quite self-explanatory and the commit message would be a copy-paste of it. OK, if you want I will add "some comment". Andi > > --- > > drivers/input/touchscreen/mms114.c | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/input/touchscreen/mms114.c b/drivers/input/touchscreen/mms114.c > > index 11dba8bb48e3..fdf23bc416af 100644 > > --- a/drivers/input/touchscreen/mms114.c > > +++ b/drivers/input/touchscreen/mms114.c > > @@ -20,7 +20,7 @@ > > > > /* Write only registers */ > > #define MMS114_MODE_CONTROL 0x01 > > -#define MMS114_OPERATION_MODE_MASK 0xE > > +#define MMS114_OPERATION_MODE_MASK 0xe > > #define MMS114_ACTIVE (1 << 1) > > > > #define MMS114_XY_RESOLUTION_H 0x02 > > @@ -30,12 +30,12 @@ > > #define MMS114_MOVING_THRESHOLD 0x06 > > > > /* Read only registers */ > > -#define MMS114_PACKET_SIZE 0x0F > > +#define MMS114_PACKET_SIZE 0x0f > > #define MMS114_INFOMATION 0x10 > > -#define MMS114_TSP_REV 0xF0 > > +#define MMS114_TSP_REV 0xf0 > > > > -#define MMS152_FW_REV 0xE1 > > -#define MMS152_COMPAT_GROUP 0xF2 > > +#define MMS152_FW_REV 0xe1 > > +#define MMS152_COMPAT_GROUP 0xf2 > > > > /* 200ms needs after power on */ > > #define MMS114_POWERON_DELAY 200 > > -- > > 2.15.1 > > > > -- > Dmitry > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jan 30, 2018 at 08:29:23AM +0900, Andi Shyti wrote: > Hi Dmitry, > > On Mon, Jan 29, 2018 at 10:56:31AM -0800, Dmitry Torokhov wrote: > > On Mon, Jan 29, 2018 at 08:33:20PM +0900, Andi Shyti wrote: > > > Signed-off-by: Andi Shyti <andi.shyti@samsung.com> > > > > But why? > > I think this patch is trivial and the subject itself is quite > self-explanatory and the commit message would be a copy-paste of > it. Here is where we disagree. Why lowercase is preferred over uppercase? Do we have this in coding style (and I completely forgot about it)? Or is it your preference (mine is too to be fair, but I also do not care about churning the code for it)? Thanks.
Hi Dmitry, On Mon, Jan 29, 2018 at 03:33:35PM -0800, Dmitry Torokhov wrote: > On Tue, Jan 30, 2018 at 08:29:23AM +0900, Andi Shyti wrote: > > Hi Dmitry, > > > > On Mon, Jan 29, 2018 at 10:56:31AM -0800, Dmitry Torokhov wrote: > > > On Mon, Jan 29, 2018 at 08:33:20PM +0900, Andi Shyti wrote: > > > > Signed-off-by: Andi Shyti <andi.shyti@samsung.com> > > > > > > But why? > > > > I think this patch is trivial and the subject itself is quite > > self-explanatory and the commit message would be a copy-paste of > > it. > > Here is where we disagree. Why lowercase is preferred over uppercase? Do > we have this in coding style (and I completely forgot about it)? Or is > it your preference (mine is too to be fair, but I also do not care > about churning the code for it)? I think this is the case where the cultural habits become law, I've been writing lower case hex values from years and my eyes are so used to it that it looks wrong to have them written upper case. Many maintainers reject upper case hex values. As well as many reject the " ? : " conditional form. In any case, you're basically right here, at this point I don't mind if you drop it :) Thanks, Andi -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/input/touchscreen/mms114.c b/drivers/input/touchscreen/mms114.c index 11dba8bb48e3..fdf23bc416af 100644 --- a/drivers/input/touchscreen/mms114.c +++ b/drivers/input/touchscreen/mms114.c @@ -20,7 +20,7 @@ /* Write only registers */ #define MMS114_MODE_CONTROL 0x01 -#define MMS114_OPERATION_MODE_MASK 0xE +#define MMS114_OPERATION_MODE_MASK 0xe #define MMS114_ACTIVE (1 << 1) #define MMS114_XY_RESOLUTION_H 0x02 @@ -30,12 +30,12 @@ #define MMS114_MOVING_THRESHOLD 0x06 /* Read only registers */ -#define MMS114_PACKET_SIZE 0x0F +#define MMS114_PACKET_SIZE 0x0f #define MMS114_INFOMATION 0x10 -#define MMS114_TSP_REV 0xF0 +#define MMS114_TSP_REV 0xf0 -#define MMS152_FW_REV 0xE1 -#define MMS152_COMPAT_GROUP 0xF2 +#define MMS152_FW_REV 0xe1 +#define MMS152_COMPAT_GROUP 0xf2 /* 200ms needs after power on */ #define MMS114_POWERON_DELAY 200
Signed-off-by: Andi Shyti <andi.shyti@samsung.com> --- drivers/input/touchscreen/mms114.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)