diff mbox

HID: i2c-hid: remove i2c_hid_open_mut

Message ID 20180529120321.15582-1-bigeasy@linutronix.de (mailing list archive)
State New, archived
Headers show

Commit Message

Sebastian Andrzej Siewior May 29, 2018, 12:03 p.m. UTC
Since commit 85ae91133152 ("HID: i2c-hid: remove custom locking from
i2c_hid_open/close") there are no more users of i2c_hid_open_mut.
Remove the unused mutex.

Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Jiri Kosina <jikos@kernel.org>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
 drivers/hid/i2c-hid/i2c-hid.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Dmitry Torokhov May 29, 2018, 6:01 p.m. UTC | #1
On Tue, May 29, 2018 at 02:03:21PM +0200, Sebastian Andrzej Siewior wrote:
> Since commit 85ae91133152 ("HID: i2c-hid: remove custom locking from
> i2c_hid_open/close") there are no more users of i2c_hid_open_mut.
> Remove the unused mutex.
> 
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Jiri Kosina <jikos@kernel.org>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

> ---
>  drivers/hid/i2c-hid/i2c-hid.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c
> index cc33622253aa..91ffc50c10a4 100644
> --- a/drivers/hid/i2c-hid/i2c-hid.c
> +++ b/drivers/hid/i2c-hid/i2c-hid.c
> @@ -131,8 +131,6 @@ static const struct i2c_hid_cmd hid_no_cmd =		{ .length = 0 };
>   * static const struct i2c_hid_cmd hid_set_protocol_cmd = { I2C_HID_CMD(0x07) };
>   */
>  
> -static DEFINE_MUTEX(i2c_hid_open_mut);
> -
>  /* The main device structure */
>  struct i2c_hid {
>  	struct i2c_client	*client;	/* i2c client */
> -- 
> 2.17.0
>
Jiri Kosina May 30, 2018, 6:49 a.m. UTC | #2
On Tue, 29 May 2018, Sebastian Andrzej Siewior wrote:

> Since commit 85ae91133152 ("HID: i2c-hid: remove custom locking from
> i2c_hid_open/close") there are no more users of i2c_hid_open_mut.
> Remove the unused mutex.
> 
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Jiri Kosina <jikos@kernel.org>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
>  drivers/hid/i2c-hid/i2c-hid.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c
> index cc33622253aa..91ffc50c10a4 100644
> --- a/drivers/hid/i2c-hid/i2c-hid.c
> +++ b/drivers/hid/i2c-hid/i2c-hid.c
> @@ -131,8 +131,6 @@ static const struct i2c_hid_cmd hid_no_cmd =		{ .length = 0 };
>   * static const struct i2c_hid_cmd hid_set_protocol_cmd = { I2C_HID_CMD(0x07) };
>   */
>  
> -static DEFINE_MUTEX(i2c_hid_open_mut);
> -

Applied to hid.git#for-4.18/i2c-hid, thanks Sebastian.
diff mbox

Patch

diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c
index cc33622253aa..91ffc50c10a4 100644
--- a/drivers/hid/i2c-hid/i2c-hid.c
+++ b/drivers/hid/i2c-hid/i2c-hid.c
@@ -131,8 +131,6 @@  static const struct i2c_hid_cmd hid_no_cmd =		{ .length = 0 };
  * static const struct i2c_hid_cmd hid_set_protocol_cmd = { I2C_HID_CMD(0x07) };
  */
 
-static DEFINE_MUTEX(i2c_hid_open_mut);
-
 /* The main device structure */
 struct i2c_hid {
 	struct i2c_client	*client;	/* i2c client */