From patchwork Sat Jul 21 19:09:50 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harshit Jain X-Patchwork-Id: 10538981 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A2763A679 for ; Sun, 22 Jul 2018 00:57:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8743B2893D for ; Sat, 21 Jul 2018 19:11:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7AD872894E; Sat, 21 Jul 2018 19:11:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 29DDE2893D for ; Sat, 21 Jul 2018 19:11:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728830AbeGUUEz (ORCPT ); Sat, 21 Jul 2018 16:04:55 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35490 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727554AbeGUUEy (ORCPT ); Sat, 21 Jul 2018 16:04:54 -0400 Received: by mail-wm0-f65.google.com with SMTP id o18-v6so1273590wmc.0; Sat, 21 Jul 2018 12:11:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=4VpnKFelclX0L+FoN8Y1vffLYVvjqWXQc+YzeGv9LVc=; b=bqUporAVlBxRBSYi7r6TtsnQcAJaU+njB+W4uuonkT/jYOd7GpfbkHlaJ963DI0E3I km7ikReXskT753OYZym+k4cSO4DnI1WUdxC4IqtfJ0QL7Vrl8cipixdLwk6XflVacRWH 07SEciW6r0U92neWi2hURVv1RvhH2Q2TQlFrOWPHXf95Kirtn3ooPGjaS3+yT4UsGoXp G4Tye+GfHJpoSaLvgo7tUI1lgkwoO8v5AxXpZXNr7EIRCh8AVuCvY0TyxhBMjjd+Xh6x B9HFy4ErcIWfqX3dG/hXQ+mfRBj6dMXyRe2b74HZv8EgYtUVD8/Y1p1Yj2sMPAZxLqZY 5RfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=4VpnKFelclX0L+FoN8Y1vffLYVvjqWXQc+YzeGv9LVc=; b=l+gKFkhU9pntavUROLaPI6XsThYoHgF4EsfOw+1OpD391mn35dkqkCEyjfuS3bpwTs /c7w4yZz6MH76Y5VavK6/Murap+J8peNCGsxS78radsavsIABzviZRpAVQc6I0mOgJSR fzD6+FTKBMOTFYfqeKoKv62f/M6K/kpLSymnTs9J6G5sQRUjqv+65GcpRS2muLlFZMKu 292USSdhJO2PmSLWigU3RmTYUBxVJoQvPyF1DOzBTEG+BtCtQKthr9NDjYykJA0p4giI ghfZlYEHv/0DMJDsubim7YrpWEgm9fBA6eKu0DByoAD6AUP9nnk2lN+unWBZaCVSWv+4 PD2A== X-Gm-Message-State: AOUpUlGHrxzYiJp+sH2OgEZ/nnFfk6kCeytZrLtS3jH9BXJ6vU4hPMOY ckiCuLuNsqtHGIoan2fo3js= X-Google-Smtp-Source: AAOMgpcKepa9pi3fg+XalEmzifS8bsj6vATyGspVsuY8HkoNhS0hAnFY39aU65MfpBzXR1HOLCmK1g== X-Received: by 2002:a1c:b84e:: with SMTP id i75-v6mr3872309wmf.158.1532200266631; Sat, 21 Jul 2018 12:11:06 -0700 (PDT) Received: from localhost.localdomain ([2a01:4f8:201:1487::2]) by smtp.gmail.com with ESMTPSA id x19-v6sm4241933wrd.32.2018.07.21.12.11.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 Jul 2018 12:11:06 -0700 (PDT) From: dev-harsh1998 To: trivial@kernel.org Cc: Dmitry Torokhov , Maxime Ripard , Chen-Yu Tsai , Andi Shyti , Simon Budig , Luca Ceresoli , Julia Lawall , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 10/11] touchscreen: sun4i_ts: Use octal permissions Date: Sun, 22 Jul 2018 00:39:50 +0530 Message-Id: <20180721191029.25658-9-harshitjain6751@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180721191029.25658-1-harshitjain6751@gmail.com> References: <20180721191029.25658-1-harshitjain6751@gmail.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(temp1_input, S_IRUGO, show_temp, NULL); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(temp1_label, S_IRUGO, show_temp_label, NULL); Signed-off-by: dev-harsh1998 --- drivers/input/touchscreen/sun4i-ts.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/sun4i-ts.c b/drivers/input/touchscreen/sun4i-ts.c index d2e14d9e5975..78960961a524 100644 --- a/drivers/input/touchscreen/sun4i-ts.c +++ b/drivers/input/touchscreen/sun4i-ts.c @@ -230,8 +230,8 @@ static ssize_t show_temp_label(struct device *dev, return sprintf(buf, "SoC temperature\n"); } -static DEVICE_ATTR(temp1_input, S_IRUGO, show_temp, NULL); -static DEVICE_ATTR(temp1_label, S_IRUGO, show_temp_label, NULL); +static DEVICE_ATTR(temp1_input, 0444, show_temp, NULL); +static DEVICE_ATTR(temp1_label, 0444, show_temp_label, NULL); static struct attribute *sun4i_ts_attrs[] = { &dev_attr_temp1_input.attr,