| Message ID | 20180823183057.247630-2-hcutts@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add support for high-resolution scrolling on Logitech mice | expand |
On Thu, Aug 23, 2018 at 11:30:55AM -0700, Harry Cutts wrote: > This event code represents scroll reports from high-resolution wheels, > and will be used by future patches in this series. See the linux-input > "Reporting high-resolution scroll events" thread [0] for more details. > > [0]: https://www.spinics.net/lists/linux-input/msg57380.html > > Signed-off-by: Harry Cutts <hcutts@chromium.org> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Jiri, Benjamin, feel free to merge through HID tree if the rest is acceptable. Thanks.
On Thu, Aug 23, 2018 at 11:30:55AM -0700, Harry Cutts wrote: > + - If a vertical scroll wheel supports high-resolution scrolling, this code > + will be emitted in addition to REL_WHEEL. The value is the (approximate) > + distance travelled by the user's finger, in 256ths of a millimeter. Is it too late to change this to an actual unit like micrometres?
On Thu, Aug 23, 2018 at 11:57:22AM -0700, Matthew Wilcox wrote: > On Thu, Aug 23, 2018 at 11:30:55AM -0700, Harry Cutts wrote: > > + - If a vertical scroll wheel supports high-resolution scrolling, this code > > + will be emitted in addition to REL_WHEEL. The value is the (approximate) > > + distance travelled by the user's finger, in 256ths of a millimeter. > > Is it too late to change this to an actual unit like micrometres? No love for imperial roots? Sure, micrometers would work too I think.
On Thu, 23 Aug 2018, Dmitry Torokhov wrote: > > > + - If a vertical scroll wheel supports high-resolution scrolling, this code > > > + will be emitted in addition to REL_WHEEL. The value is the (approximate) > > > + distance travelled by the user's finger, in 256ths of a millimeter. > > > > Is it too late to change this to an actual unit like micrometres? > > No love for imperial roots? Sure, micrometers would work too I think. I don't really care strongly :) Is either of you going to update the patch? Otherwise I'll just apply as-is. Thanks,
Benjamin says he prefers micrometres, and I think I do to now that I think about it (sticking with SI seems like a good idea), so I'll update it in a V2. Harry Cutts Chrome OS Touch/Input team Harry Cutts Chrome OS Touch/Input team On Tue, 28 Aug 2018 at 02:02, Jiri Kosina <jikos@kernel.org> wrote: > > On Thu, 23 Aug 2018, Dmitry Torokhov wrote: > > > > > + - If a vertical scroll wheel supports high-resolution scrolling, this code > > > > + will be emitted in addition to REL_WHEEL. The value is the (approximate) > > > > + distance travelled by the user's finger, in 256ths of a millimeter. > > > > > > Is it too late to change this to an actual unit like micrometres? > > > > No love for imperial roots? Sure, micrometers would work too I think. > > I don't really care strongly :) Is either of you going to update the > patch? Otherwise I'll just apply as-is. > > Thanks, > > -- > Jiri Kosina > SUSE Labs >
diff --git a/Documentation/input/event-codes.rst b/Documentation/input/event-codes.rst index a8c0873beb95..df024cb82829 100644 --- a/Documentation/input/event-codes.rst +++ b/Documentation/input/event-codes.rst @@ -190,7 +190,16 @@ A few EV_REL codes have special meanings: * REL_WHEEL, REL_HWHEEL: - These codes are used for vertical and horizontal scroll wheels, - respectively. + respectively. The value is the number of "notches" moved on the wheel, the + physical size of which varies by device. For high-resolution wheels (which + report multiple events for each notch of movement, or do not have notches) + this may be an approximation based on the high-resolution scroll events. + +* REL_WHEEL_HI_RES: + + - If a vertical scroll wheel supports high-resolution scrolling, this code + will be emitted in addition to REL_WHEEL. The value is the (approximate) + distance travelled by the user's finger, in 256ths of a millimeter. EV_ABS ------ diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h index 53fbae27b280..dad8d3890a3a 100644 --- a/include/uapi/linux/input-event-codes.h +++ b/include/uapi/linux/input-event-codes.h @@ -708,6 +708,7 @@ #define REL_DIAL 0x07 #define REL_WHEEL 0x08 #define REL_MISC 0x09 +#define REL_WHEEL_HI_RES 0x0a #define REL_MAX 0x0f #define REL_CNT (REL_MAX+1)
This event code represents scroll reports from high-resolution wheels, and will be used by future patches in this series. See the linux-input "Reporting high-resolution scroll events" thread [0] for more details. [0]: https://www.spinics.net/lists/linux-input/msg57380.html Signed-off-by: Harry Cutts <hcutts@chromium.org> --- Documentation/input/event-codes.rst | 11 ++++++++++- include/uapi/linux/input-event-codes.h | 1 + 2 files changed, 11 insertions(+), 1 deletion(-)