diff mbox series

HID: elan: Make array buf static, shrinks object size

Message ID 20180926084150.17514-1-colin.king@canonical.com (mailing list archive)
State Mainlined
Commit 8471300fce4cf2593267d07d6db50709c89049b4
Delegated to: Jiri Kosina
Headers show
Series HID: elan: Make array buf static, shrinks object size | expand

Commit Message

Colin Ian King Sept. 26, 2018, 8:41 a.m. UTC
From: Colin Ian King <colin.king@canonical.com>

Don't populate the array buf on the stack but instead make it
static. Makes the object code smaller by 43 bytes:

Before:
   text	   data	    bss	    dec	    hex	filename
   7769	   1520	      0	   9289	   2449	drivers/hid/hid-elan.o

After:
   text	   data	    bss	    dec	    hex	filename
   7662	   1584	      0	   9246	   241e	drivers/hid/hid-elan.o

(gcc version 8.2.0 x86_64)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/hid/hid-elan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Colin Ian King Jan. 24, 2019, 4:54 p.m. UTC | #1
ping?

On 26/09/2018 09:41, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Don't populate the array buf on the stack but instead make it
> static. Makes the object code smaller by 43 bytes:
> 
> Before:
>    text	   data	    bss	    dec	    hex	filename
>    7769	   1520	      0	   9289	   2449	drivers/hid/hid-elan.o
> 
> After:
>    text	   data	    bss	    dec	    hex	filename
>    7662	   1584	      0	   9246	   241e	drivers/hid/hid-elan.o
> 
> (gcc version 8.2.0 x86_64)
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/hid/hid-elan.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-elan.c b/drivers/hid/hid-elan.c
> index 07e26c3567eb..05377eec2cb2 100644
> --- a/drivers/hid/hid-elan.c
> +++ b/drivers/hid/hid-elan.c
> @@ -393,7 +393,7 @@ static int elan_start_multitouch(struct hid_device *hdev)
>  	 * This byte sequence will enable multitouch mode and disable
>  	 * mouse emulation
>  	 */
> -	const unsigned char buf[] = { 0x0D, 0x00, 0x03, 0x21, 0x00 };
> +	static const unsigned char buf[] = { 0x0D, 0x00, 0x03, 0x21, 0x00 };
>  	unsigned char *dmabuf = kmemdup(buf, sizeof(buf), GFP_KERNEL);
>  
>  	if (!dmabuf)
>
Jiri Kosina Jan. 25, 2019, 3:53 p.m. UTC | #2
On Thu, 24 Jan 2019, Colin Ian King wrote:

> ping?

I don't think I've ever seen the original patch in my inbox. Could you 
please just resend it?
diff mbox series

Patch

diff --git a/drivers/hid/hid-elan.c b/drivers/hid/hid-elan.c
index 07e26c3567eb..05377eec2cb2 100644
--- a/drivers/hid/hid-elan.c
+++ b/drivers/hid/hid-elan.c
@@ -393,7 +393,7 @@  static int elan_start_multitouch(struct hid_device *hdev)
 	 * This byte sequence will enable multitouch mode and disable
 	 * mouse emulation
 	 */
-	const unsigned char buf[] = { 0x0D, 0x00, 0x03, 0x21, 0x00 };
+	static const unsigned char buf[] = { 0x0D, 0x00, 0x03, 0x21, 0x00 };
 	unsigned char *dmabuf = kmemdup(buf, sizeof(buf), GFP_KERNEL);
 
 	if (!dmabuf)