| Message ID | 20181005005432.GA218507@dtor-ws (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Input: uinput - add a schedule point in uinput_inject_events() | expand |
On Thu, Oct 04, 2018 at 05:54:32PM -0700, Dmitry Torokhov wrote: > Large writes to uinput interface may cause rcu stalls. Let's add > cond_resched() to the loop to avoid this. > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Reviewed-by: Paul E. McKenney <paulmck@linux.ibm.com> > --- > drivers/input/misc/uinput.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/input/misc/uinput.c b/drivers/input/misc/uinput.c > index eb14ddf69346..8ec483e8688b 100644 > --- a/drivers/input/misc/uinput.c > +++ b/drivers/input/misc/uinput.c > @@ -598,6 +598,7 @@ static ssize_t uinput_inject_events(struct uinput_device *udev, > > input_event(udev->dev, ev.type, ev.code, ev.value); > bytes += input_event_size(); > + cond_resched(); > } > > return bytes; > -- > 2.19.0.605.g01d371f741-goog > > > -- > Dmitry >
diff --git a/drivers/input/misc/uinput.c b/drivers/input/misc/uinput.c index eb14ddf69346..8ec483e8688b 100644 --- a/drivers/input/misc/uinput.c +++ b/drivers/input/misc/uinput.c @@ -598,6 +598,7 @@ static ssize_t uinput_inject_events(struct uinput_device *udev, input_event(udev->dev, ev.type, ev.code, ev.value); bytes += input_event_size(); + cond_resched(); } return bytes;
Large writes to uinput interface may cause rcu stalls. Let's add cond_resched() to the loop to avoid this. Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> --- drivers/input/misc/uinput.c | 1 + 1 file changed, 1 insertion(+)