| Message ID | 20181010142504.233467-6-lkundrak@v3.sk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | OLPC 1.75 Keyboard/Touchpad fixes | expand |
On Wed, Oct 10, 2018 at 04:25:01PM +0200, Lubomir Rintel wrote: > This is a device-tree enabled driver. Moreover CONFIG_OLPC is specific > to the x86 platform code, while the driver is for an ARM-based laptop. > > Signed-off-by: Lubomir Rintel <lkundrak@v3.sk> > --- > drivers/input/serio/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/serio/Kconfig b/drivers/input/serio/Kconfig > index d90d9f1098ff..a4f70021b53e 100644 > --- a/drivers/input/serio/Kconfig > +++ b/drivers/input/serio/Kconfig > @@ -254,7 +254,7 @@ config SERIO_APBPS2 > > config SERIO_OLPC_APSP > tristate "OLPC AP-SP input support" > - depends on OLPC || COMPILE_TEST > + depends on OF I do not see anything in the driver that depends on OF. If OLPC is not right dependency, then let's drop the whole depends. Are you going to be submitting DTS files for the platform? Thanks.
On Wed 2018-10-10 16:25:01, Lubomir Rintel wrote: > This is a device-tree enabled driver. Moreover CONFIG_OLPC is specific > to the x86 platform code, while the driver is for an ARM-based laptop. > > Signed-off-by: Lubomir Rintel <lkundrak@v3.sk> > --- > drivers/input/serio/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/serio/Kconfig b/drivers/input/serio/Kconfig > index d90d9f1098ff..a4f70021b53e 100644 > --- a/drivers/input/serio/Kconfig > +++ b/drivers/input/serio/Kconfig > @@ -254,7 +254,7 @@ config SERIO_APBPS2 > > config SERIO_OLPC_APSP > tristate "OLPC AP-SP input support" > - depends on OLPC || COMPILE_TEST > + depends on OF I'd keep "|| COMPILE_TEST". Otherwise Acked-by: Pavel Machek <pavel@ucw.cz> Pavel
diff --git a/drivers/input/serio/Kconfig b/drivers/input/serio/Kconfig index d90d9f1098ff..a4f70021b53e 100644 --- a/drivers/input/serio/Kconfig +++ b/drivers/input/serio/Kconfig @@ -254,7 +254,7 @@ config SERIO_APBPS2 config SERIO_OLPC_APSP tristate "OLPC AP-SP input support" - depends on OLPC || COMPILE_TEST + depends on OF help Say Y here if you want support for the keyboard and touchpad included in the OLPC XO-1.75 and XO-4 laptops.
This is a device-tree enabled driver. Moreover CONFIG_OLPC is specific to the x86 platform code, while the driver is for an ARM-based laptop. Signed-off-by: Lubomir Rintel <lkundrak@v3.sk> --- drivers/input/serio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)