| Message ID | 20181017070153.465-1-benjamin.tissoires@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Jiri Kosina |
| Headers | show |
| Series | Revert "HID: add NOGET quirk for Eaton Ellipse MAX UPS" | expand |
On Wed, 17 Oct 2018, Benjamin Tissoires wrote: > This reverts commit 67ddbb3e6568fb1820b2cc45b00c50702b114801. > > 67ddbb3e656 ("HID: add NOGET quirk for Eaton Ellipse MAX UPS") was reported > by Laurent Bigonville. It turns out that a later model Laurent got > doesn't need the quirk after all. > > My take is that Eaton upgraded their firmwares, so we don't need it > anymore. > > The old model was from 2012, so better make sure the new line works > properly by removing the quirk. This allows upower to actually fetch > the current data. > > Reported-by: Laurent Bigonville <bigon@bigon.be> > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Ok, fingers crossed. Applied,
diff --git a/drivers/hid/hid-quirks.c b/drivers/hid/hid-quirks.c index 279f410618c6..e260bdeb51a7 100644 --- a/drivers/hid/hid-quirks.c +++ b/drivers/hid/hid-quirks.c @@ -107,7 +107,6 @@ static const struct hid_device_id hid_quirks[] = { { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_MOUSE_C05A), HID_QUIRK_ALWAYS_POLL }, { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_MOUSE_C06A), HID_QUIRK_ALWAYS_POLL }, { HID_USB_DEVICE(USB_VENDOR_ID_MCS, USB_DEVICE_ID_MCS_GAMEPADBLOCK), HID_QUIRK_MULTI_INPUT }, - { HID_USB_DEVICE(USB_VENDOR_ID_MGE, USB_DEVICE_ID_MGE_UPS), HID_QUIRK_NOGET }, { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_POWER_COVER), HID_QUIRK_NO_INIT_REPORTS }, { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_SURFACE_PRO_2), HID_QUIRK_NO_INIT_REPORTS }, { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TOUCH_COVER_2), HID_QUIRK_NO_INIT_REPORTS },
This reverts commit 67ddbb3e6568fb1820b2cc45b00c50702b114801. 67ddbb3e656 ("HID: add NOGET quirk for Eaton Ellipse MAX UPS") was reported by Laurent Bigonville. It turns out that a later model Laurent got doesn't need the quirk after all. My take is that Eaton upgraded their firmwares, so we don't need it anymore. The old model was from 2012, so better make sure the new line works properly by removing the quirk. This allows upower to actually fetch the current data. Reported-by: Laurent Bigonville <bigon@bigon.be> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> --- drivers/hid/hid-quirks.c | 1 - 1 file changed, 1 deletion(-)