From patchwork Thu Mar 21 08:21:02 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 10863027 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 36ED51575 for ; Thu, 21 Mar 2019 08:21:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1E92B29F21 for ; Thu, 21 Mar 2019 08:21:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1275829FEC; Thu, 21 Mar 2019 08:21:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 01F2629F21 for ; Thu, 21 Mar 2019 08:21:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728017AbfCUIVZ (ORCPT ); Thu, 21 Mar 2019 04:21:25 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:44012 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728016AbfCUIVZ (ORCPT ); Thu, 21 Mar 2019 04:21:25 -0400 Received: by mail-pg1-f195.google.com with SMTP id l11so3692698pgq.10 for ; Thu, 21 Mar 2019 01:21:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=z/xVWk5dO82lfFtPDZKsgcg1B373xfEKm8H/gQlJdy0=; b=BI0LV8Tt8sSLmhJe3nAFyPo7lb8y/OS0Gr5C9Lq776TM8mqM3139hGFjSJo6IGbs7D P6YmUlG9rivqEbPZ6Ld/k7M38Ptt1WM8J1KiQBqyOJKmv6u4pvz4XV+wC8IS13DhdZ5U hgi30t3VQhBFAzs5QJ0r35KnTw639Y688lVjc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=z/xVWk5dO82lfFtPDZKsgcg1B373xfEKm8H/gQlJdy0=; b=C0y9IaZmTWpy7tF+nN74VsVWJyo3bLQUCvIhXEocX+hN4h8uR7mtt7yJqzfMlT6tnh rpjn4EUKmxhHhXrHMYliclZJAgVeFdTwBI5aIJl7IKe0xWHf6eDVRR8x4TEyrDA6tqwl bXSFrJYown+miHF1Kr4P1jGmqo4cwpvMyYz58gtlzQz79hIQ8M0HFIoxEcSMclZLrzsQ kYRfE34XHSpkxnGDVsydtweh76PfAXEeGuUlQeCnWdkNRltk9wFhhJcznpnqgGereJo7 XkcPL5BrxjavMzhQtf6ErhRKXPlZ2iHKPIUqT24agI9lUTneTfzXityANWs7wlVFBFQ2 ZUHg== X-Gm-Message-State: APjAAAVMCG8nyAL/VOow59zfdgYJQnhcVezbN+GA/pM0qvr0LqlrS8l9 grTrNFA9/iBsv68ACksMQIQsHg== X-Google-Smtp-Source: APXvYqzWCnQK3/GdCmEVC61sBBIBJyff2uu2R7M0sbChSWzOx/5oKkQTwWB5oeyLnwr3dEymFKDjBw== X-Received: by 2002:aa7:82d7:: with SMTP id f23mr2151127pfn.114.1553156484117; Thu, 21 Mar 2019 01:21:24 -0700 (PDT) Received: from localhost.localdomain ([49.206.202.234]) by smtp.gmail.com with ESMTPSA id b138sm6288681pfb.48.2019.03.21.01.21.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Mar 2019 01:21:23 -0700 (PDT) From: Jagan Teki To: Dmitry Torokhov , Bastien Nocera , Rob Herring Cc: Henrik Rydberg , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Mark Rutland , linux-amarula@amarulasolutions.com, Michael Trimarchi , Jagan Teki Subject: [PATCH v7 2/4] Input: goodix - Add regulators suppot Date: Thu, 21 Mar 2019 13:51:02 +0530 Message-Id: <20190321082104.2874-3-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.18.0.321.gffc6fa0e3 In-Reply-To: <20190321082104.2874-1-jagan@amarulasolutions.com> References: <20190321082104.2874-1-jagan@amarulasolutions.com> MIME-Version: 1.0 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Goodix CTP controllers require AVDD28, VDDIO regulators for power-on sequence. The delay between these regualtor operations as per Power-on Timing from datasheet[1] is 0 (T1 >= 0 usec). So, enable and disable these regulators in proper order using normal regulator functions without any delay in between. [1] GT5663 Datasheet_English_20151106_Rev.01 Signed-off-by: Jagan Teki --- drivers/input/touchscreen/goodix.c | 58 ++++++++++++++++++++++++++++++ 1 file changed, 58 insertions(+) diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c index f57d82220a88..de5b80a08f41 100644 --- a/drivers/input/touchscreen/goodix.c +++ b/drivers/input/touchscreen/goodix.c @@ -27,6 +27,7 @@ #include #include #include +#include #include #include #include @@ -47,6 +48,8 @@ struct goodix_ts_data { struct touchscreen_properties prop; unsigned int max_touch_num; unsigned int int_trigger_type; + struct regulator *avdd28; + struct regulator *vddio; struct gpio_desc *gpiod_int; struct gpio_desc *gpiod_rst; u16 id; @@ -532,6 +535,24 @@ static int goodix_get_gpio_config(struct goodix_ts_data *ts) return -EINVAL; dev = &ts->client->dev; + ts->avdd28 = devm_regulator_get(dev, "AVDD28"); + if (IS_ERR(ts->avdd28)) { + error = PTR_ERR(ts->avdd28); + if (error != -EPROBE_DEFER) + dev_err(dev, + "Failed to get AVDD28 regulator: %d\n", error); + return error; + } + + ts->vddio = devm_regulator_get(dev, "VDDIO"); + if (IS_ERR(ts->vddio)) { + error = PTR_ERR(ts->vddio); + if (error != -EPROBE_DEFER) + dev_err(dev, + "Failed to get VDDIO regulator: %d\n", error); + return error; + } + /* Get the interrupt GPIO pin number */ gpiod = devm_gpiod_get_optional(dev, GOODIX_GPIO_INT_NAME, GPIOD_IN); if (IS_ERR(gpiod)) { @@ -764,6 +785,17 @@ static void goodix_config_cb(const struct firmware *cfg, void *ctx) complete_all(&ts->firmware_loading_complete); } +static void goodix_disable_regulator(void *arg) +{ + struct goodix_ts_data *ts = arg; + + if (!IS_ERR(ts->vddio)) + regulator_disable(ts->vddio); + + if (!IS_ERR(ts->avdd28)) + regulator_disable(ts->avdd28); +} + static int goodix_ts_probe(struct i2c_client *client, const struct i2c_device_id *id) { @@ -789,6 +821,32 @@ static int goodix_ts_probe(struct i2c_client *client, if (error) return error; + error = devm_add_action_or_reset(&client->dev, + goodix_disable_regulator, ts); + if (error) + return error; + + /* power the controller */ + if (!IS_ERR(ts->avdd28)) { + error = regulator_enable(ts->avdd28); + if (error) { + dev_err(&client->dev, + "Failed to enable AVDD28 regulator: %d\n", + error); + return error; + } + } + + if (!IS_ERR(ts->vddio)) { + error = regulator_enable(ts->vddio); + if (error) { + dev_err(&client->dev, + "Failed to enable VDDIO regulator: %d\n", + error); + return error; + } + } + if (ts->gpiod_int && ts->gpiod_rst) { /* reset the controller */ error = goodix_reset(ts);