| Message ID | 20191024115909.109402-1-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | c07a0254c89e4bb69ca781cd488baa5b628e2754 |
| Delegated to: | Jiri Kosina |
| Headers | show |
| Series | HID: asus: Ignore Asus vendor-page usage-code 0xff events | expand |
On Thu, 24 Oct 2019, Hans de Goede wrote: > At least on a T100HA an Asus vendor-page usage-code 0xff event is send on > every suspend and again on resume, resulting in the following warning: > > asus 0003:0B05:1807.0002: Unmapped Asus vendor usagepage code 0xff > > being logged twice on every suspend/resume. > > This commit silences the "Unmapped Asus vendor usagepage code ..." > warning for usage-code 0xff to avoid these warnings being logged. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > drivers/hid/hid-asus.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c > index 8063b1d567b1..e6e4c841fb06 100644 > --- a/drivers/hid/hid-asus.c > +++ b/drivers/hid/hid-asus.c > @@ -261,7 +261,8 @@ static int asus_event(struct hid_device *hdev, struct hid_field *field, > struct hid_usage *usage, __s32 value) > { > if ((usage->hid & HID_USAGE_PAGE) == 0xff310000 && > - (usage->hid & HID_USAGE) != 0x00 && !usage->type) { > + (usage->hid & HID_USAGE) != 0x00 && > + (usage->hid & HID_USAGE) != 0xff && !usage->type) { > hid_warn(hdev, "Unmapped Asus vendor usagepage code 0x%02x\n", > usage->hid & HID_USAGE); Applied, thanks.
diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c index 8063b1d567b1..e6e4c841fb06 100644 --- a/drivers/hid/hid-asus.c +++ b/drivers/hid/hid-asus.c @@ -261,7 +261,8 @@ static int asus_event(struct hid_device *hdev, struct hid_field *field, struct hid_usage *usage, __s32 value) { if ((usage->hid & HID_USAGE_PAGE) == 0xff310000 && - (usage->hid & HID_USAGE) != 0x00 && !usage->type) { + (usage->hid & HID_USAGE) != 0x00 && + (usage->hid & HID_USAGE) != 0xff && !usage->type) { hid_warn(hdev, "Unmapped Asus vendor usagepage code 0x%02x\n", usage->hid & HID_USAGE); }
At least on a T100HA an Asus vendor-page usage-code 0xff event is send on every suspend and again on resume, resulting in the following warning: asus 0003:0B05:1807.0002: Unmapped Asus vendor usagepage code 0xff being logged twice on every suspend/resume. This commit silences the "Unmapped Asus vendor usagepage code ..." warning for usage-code 0xff to avoid these warnings being logged. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/hid/hid-asus.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)