| Message ID | 20191125211407.GA97812@dtor-ws (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 1e55c176f8f503c7dccba6e2b237f26a065ff79c |
| Headers | show |
| Series | Input: snvs_pwrkey - remove gratuitous NULL initializers | expand |
> Subject: [PATCH] Input: snvs_pwrkey - remove gratuitous NULL initializers > > Gratuitous NULL initializers rarely help and often prevent compiler from > warning about using uninitialized variable. Let's remove them. > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Reviewed-by: Anson Huang <Anson.Huang@nxp.com> > --- > drivers/input/keyboard/snvs_pwrkey.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/keyboard/snvs_pwrkey.c > b/drivers/input/keyboard/snvs_pwrkey.c > index fd6f244f403d..2f5e3ab5ed63 100644 > --- a/drivers/input/keyboard/snvs_pwrkey.c > +++ b/drivers/input/keyboard/snvs_pwrkey.c > @@ -108,8 +108,8 @@ static void imx_snvs_pwrkey_act(void *pdata) > > static int imx_snvs_pwrkey_probe(struct platform_device *pdev) { > - struct pwrkey_drv_data *pdata = NULL; > - struct input_dev *input = NULL; > + struct pwrkey_drv_data *pdata; > + struct input_dev *input; > struct device_node *np; > int error; > u32 vid; > -- > 2.24.0.432.g9d3f5f5b63-goog > > > -- > Dmitry
diff --git a/drivers/input/keyboard/snvs_pwrkey.c b/drivers/input/keyboard/snvs_pwrkey.c index fd6f244f403d..2f5e3ab5ed63 100644 --- a/drivers/input/keyboard/snvs_pwrkey.c +++ b/drivers/input/keyboard/snvs_pwrkey.c @@ -108,8 +108,8 @@ static void imx_snvs_pwrkey_act(void *pdata) static int imx_snvs_pwrkey_probe(struct platform_device *pdev) { - struct pwrkey_drv_data *pdata = NULL; - struct input_dev *input = NULL; + struct pwrkey_drv_data *pdata; + struct input_dev *input; struct device_node *np; int error; u32 vid;
Gratuitous NULL initializers rarely help and often prevent compiler from warning about using uninitialized variable. Let's remove them. Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> --- drivers/input/keyboard/snvs_pwrkey.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)