| Message ID | 20200307213508.267187-1-dev@pp3345.net (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 1369d0abe469fb4cdea8a5bce219d38cb857a658 |
| Headers | show |
| Series | Input: synaptics - Enable RMI on HP Envy 13-ad105ng | expand |
Hi Yussuf, On Sat, Mar 07, 2020 at 10:35:08PM +0100, Yussuf Khalil wrote: > This laptop (and perhaps other variants of the same model) reports an > SMBus-capable Synaptics touchpad. Everything (including suspend and > resume) works fine when RMI is enabled via the kernel command line, so > let's add it to the whitelist. Are there issues with the touchpad when it works in the legacy (PS/2) mode? I will be applying your patch, I just need to understand if it needs to go into stable series, or we can just get it into 5.6 and later versions. Thanks!
Hi Dmitry, I currently don't have access to the device anymore, but apart from missing gesture functionality, it seemed to have some issues with selecting text by clicking and moving the cursor when running in PS/2 mode, so I guess it might be good to push the patch to stable. Regards Yussuf Khalil > Hi Yussuf, > > On Sat, Mar 07, 2020 at 10:35:08PM +0100, Yussuf Khalil wrote: >> This laptop (and perhaps other variants of the same model) reports an >> SMBus-capable Synaptics touchpad. Everything (including suspend and >> resume) works fine when RMI is enabled via the kernel command line, so >> let's add it to the whitelist. > > Are there issues with the touchpad when it works in the legacy (PS/2) > mode? I will be applying your patch, I just need to understand if it > needs to go into stable series, or we can just get it into 5.6 and later > versions. > > Thanks! >
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c index 2c666fb34625..4d2036209b45 100644 --- a/drivers/input/mouse/synaptics.c +++ b/drivers/input/mouse/synaptics.c @@ -186,6 +186,7 @@ static const char * const smbus_pnp_ids[] = { "SYN3052", /* HP EliteBook 840 G4 */ "SYN3221", /* HP 15-ay000 */ "SYN323d", /* HP Spectre X360 13-w013dx */ + "SYN3257", /* HP Envy 13-ad105ng */ NULL };
This laptop (and perhaps other variants of the same model) reports an SMBus-capable Synaptics touchpad. Everything (including suspend and resume) works fine when RMI is enabled via the kernel command line, so let's add it to the whitelist. Signed-off-by: Yussuf Khalil <dev@pp3345.net> --- drivers/input/mouse/synaptics.c | 1 + 1 file changed, 1 insertion(+)