Message ID | 20200507151213.792640-1-hslester96@gmail.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | Input: stmpe-ts - add missed input_unregister_device | expand |
On Thu, May 07, 2020 at 11:12:13PM +0800, Chuhong Yuan wrote: > This driver calls input_register_device() in probe, but misses > input_unregister_device() in remove. > Add the missed function call to fix it. The input device in question is devm-managed and therefore does not need explicit unregistering. Thanks.
diff --git a/drivers/input/touchscreen/stmpe-ts.c b/drivers/input/touchscreen/stmpe-ts.c index 7e16fcfe3b95..5e62b466629b 100644 --- a/drivers/input/touchscreen/stmpe-ts.c +++ b/drivers/input/touchscreen/stmpe-ts.c @@ -350,6 +350,7 @@ static int stmpe_ts_remove(struct platform_device *pdev) { struct stmpe_touch *ts = platform_get_drvdata(pdev); + input_unregister_device(ts->idev); stmpe_disable(ts->stmpe, STMPE_BLOCK_TOUCHSCREEN); return 0;
This driver calls input_register_device() in probe, but misses input_unregister_device() in remove. Add the missed function call to fix it. Signed-off-by: Chuhong Yuan <hslester96@gmail.com> --- drivers/input/touchscreen/stmpe-ts.c | 1 + 1 file changed, 1 insertion(+)