diff mbox series

Input: trackpoint - add new trackpoint variant IDs

Message ID 20200909083632.12971-1-vincent.huang@tw.synaptics.com (mailing list archive)
State Superseded
Headers show
Series Input: trackpoint - add new trackpoint variant IDs | expand

Commit Message

Vincent Huang Sept. 9, 2020, 8:36 a.m. UTC
Add trackpoint variant IDs to allow supported control
on Synaptics trackpoints

Signed-off-by: Vincent Huang <vincent.huang@tw.synaptics.com>
---
 drivers/input/mouse/trackpoint.c | 2 ++
 drivers/input/mouse/trackpoint.h | 2 ++
 2 files changed, 4 insertions(+)

Comments

Dmitry Torokhov Sept. 14, 2020, 5:57 a.m. UTC | #1
Hi Vincent,

On Wed, Sep 09, 2020 at 04:36:32PM +0800, Vincent Huang wrote:
> Add trackpoint variant IDs to allow supported control
> on Synaptics trackpoints
> 
> Signed-off-by: Vincent Huang <vincent.huang@tw.synaptics.com>
> ---
>  drivers/input/mouse/trackpoint.c | 2 ++
>  drivers/input/mouse/trackpoint.h | 2 ++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/drivers/input/mouse/trackpoint.c b/drivers/input/mouse/trackpoint.c
> index 3eefee2ee2a1..c54d2f9e1c4a 100644
> --- a/drivers/input/mouse/trackpoint.c
> +++ b/drivers/input/mouse/trackpoint.c
> @@ -21,6 +21,8 @@ static const char * const trackpoint_variants[] = {
>  	[TP_VARIANT_ALPS]	= "ALPS",
>  	[TP_VARIANT_ELAN]	= "Elan",
>  	[TP_VARIANT_NXP]	= "NXP",
> +	[TP_VARIANT_JYT_SYNAPTICS]	= "JYT_SYNAPTICS",
> +	[TP_VARIANT_SYNAPTICS]	= "SYNAPTICS",

Do these need to be capitalized? This is simply used in log messages, so
nicer formatted strings can be used.

Thanks.
diff mbox series

Patch

diff --git a/drivers/input/mouse/trackpoint.c b/drivers/input/mouse/trackpoint.c
index 3eefee2ee2a1..c54d2f9e1c4a 100644
--- a/drivers/input/mouse/trackpoint.c
+++ b/drivers/input/mouse/trackpoint.c
@@ -21,6 +21,8 @@  static const char * const trackpoint_variants[] = {
 	[TP_VARIANT_ALPS]	= "ALPS",
 	[TP_VARIANT_ELAN]	= "Elan",
 	[TP_VARIANT_NXP]	= "NXP",
+	[TP_VARIANT_JYT_SYNAPTICS]	= "JYT_SYNAPTICS",
+	[TP_VARIANT_SYNAPTICS]	= "SYNAPTICS",
 };
 
 /*
diff --git a/drivers/input/mouse/trackpoint.h b/drivers/input/mouse/trackpoint.h
index 5cb93ed26085..42eda7d4ba08 100644
--- a/drivers/input/mouse/trackpoint.h
+++ b/drivers/input/mouse/trackpoint.h
@@ -28,6 +28,8 @@ 
 #define TP_VARIANT_ALPS		0x02
 #define TP_VARIANT_ELAN		0x03
 #define TP_VARIANT_NXP		0x04
+#define TP_VARIANT_JYT_SYNAPTICS		0x05
+#define TP_VARIANT_SYNAPTICS		0x06
 
 /*
  * Commands