| Message ID | 20201023162220.v2.2.Ibb28033c81d87fcc13a6ba28c6ea7ac154d65f93@changeid (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/3] dt-bindings: HID: i2c-hid: Label this binding as deprecated | expand |
Hi, On Fri, Oct 23, 2020 at 4:23 PM Douglas Anderson <dianders@chromium.org> wrote: > > +examples: > + - | > + #include <dt-bindings/clock/qcom,rpmh.h> > + #include <dt-bindings/gpio/gpio.h> > + #include <dt-bindings/interrupt-controller/irq.h> > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + ap_ts: touchscreen@5d { > + compatible = "hid-over-i2c"; You always find one more problem right after you hit send, don't you? Or is that just me? Obviously the above should say compatible = "goodix,gt7375p"; Luckily when I change that "dt_binding_check" still passes. Whew! I won't send a v3 yet and I'll wait for feedback. On the off chance that there are no other problems with this binding and the maintainer wants to land this, I don't have any objections to the maintainer fixing this when the patch lands. -Doug
Hi Doug, On Sat, Oct 24, 2020 at 1:23 AM Douglas Anderson <dianders@chromium.org> wrote: > > This adds new bindings for the Goodix GT7375P touchscreen. While this > touchscreen works with generic "i2c-over-hid", the current advice is > to give it its own compatible string. The cleanest way to do this is > to give it its own bindings. > > Among other things, this has the advantage that we can list the two > possible i2c addresses for this device, which gives extra checking. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- > > Changes in v2: > - ("dt-bindings: HID: i2c-hid: Introduce bindings for the Goodix GT7375P") new in v2. > > .../bindings/input/goodix,gt7375p.yaml | 64 +++++++++++++++++++ > 1 file changed, 64 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/goodix,gt7375p.yaml > > diff --git a/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml b/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml > new file mode 100644 > index 000000000000..b5008f89e26c > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml > @@ -0,0 +1,64 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/input/goodix,gt7375p.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Goodix GT7375P touchscreen > + > +maintainers: > + - Benjamin Tissoires <benjamin.tissoires@redhat.com> Given my answer in patch 1, I am not very happy being added as a maintainer here. Cheers, Benjamin > + - Douglas Anderson <dianders@chromium.org> > + > +description: > + Supports the Goodix GT7375P touchscreen. > + > +properties: > + compatible: > + items: > + - const: goodix,gt7375p > + > + reg: > + enum: > + - 0x5d > + - 0x14 > + > + interrupts: > + maxItems: 1 > + > + reset-gpios: > + true > + > + vdd-supply: > + description: The 3.3V supply to the touchscreen. > + > +required: > + - compatible > + - reg > + - interrupts > + - reset-gpios > + - vdd-supply > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/qcom,rpmh.h> > + #include <dt-bindings/gpio/gpio.h> > + #include <dt-bindings/interrupt-controller/irq.h> > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + ap_ts: touchscreen@5d { > + compatible = "hid-over-i2c"; > + reg = <0x5d>; > + > + interrupt-parent = <&tlmm>; > + interrupts = <9 IRQ_TYPE_LEVEL_LOW>; > + > + reset-gpios = <&tlmm 8 GPIO_ACTIVE_LOW>; > + vdd-supply = <&pp3300_ts>; > + }; > + }; > -- > 2.29.0.rc1.297.gfa9743e501-goog >
diff --git a/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml b/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml new file mode 100644 index 000000000000..b5008f89e26c --- /dev/null +++ b/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml @@ -0,0 +1,64 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/input/goodix,gt7375p.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Goodix GT7375P touchscreen + +maintainers: + - Benjamin Tissoires <benjamin.tissoires@redhat.com> + - Douglas Anderson <dianders@chromium.org> + +description: + Supports the Goodix GT7375P touchscreen. + +properties: + compatible: + items: + - const: goodix,gt7375p + + reg: + enum: + - 0x5d + - 0x14 + + interrupts: + maxItems: 1 + + reset-gpios: + true + + vdd-supply: + description: The 3.3V supply to the touchscreen. + +required: + - compatible + - reg + - interrupts + - reset-gpios + - vdd-supply + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/qcom,rpmh.h> + #include <dt-bindings/gpio/gpio.h> + #include <dt-bindings/interrupt-controller/irq.h> + + i2c { + #address-cells = <1>; + #size-cells = <0>; + + ap_ts: touchscreen@5d { + compatible = "hid-over-i2c"; + reg = <0x5d>; + + interrupt-parent = <&tlmm>; + interrupts = <9 IRQ_TYPE_LEVEL_LOW>; + + reset-gpios = <&tlmm 8 GPIO_ACTIVE_LOW>; + vdd-supply = <&pp3300_ts>; + }; + };
This adds new bindings for the Goodix GT7375P touchscreen. While this touchscreen works with generic "i2c-over-hid", the current advice is to give it its own compatible string. The cleanest way to do this is to give it its own bindings. Among other things, this has the advantage that we can list the two possible i2c addresses for this device, which gives extra checking. Signed-off-by: Douglas Anderson <dianders@chromium.org> --- Changes in v2: - ("dt-bindings: HID: i2c-hid: Introduce bindings for the Goodix GT7375P") new in v2. .../bindings/input/goodix,gt7375p.yaml | 64 +++++++++++++++++++ 1 file changed, 64 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/goodix,gt7375p.yaml