| Message ID | 20201120073920.3214492-1-dmitry.torokhov@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3e35c1946805b3ecc7967e0df2bd95a7d0e0bff1 |
| Headers | show |
| Series | [1/2] Input: adp5589 - do not unconditionally configure as wakeup source | expand |
diff --git a/drivers/input/keyboard/adp5589-keys.c b/drivers/input/keyboard/adp5589-keys.c index e2cdf14d90cd..d76b0e4e67c4 100644 --- a/drivers/input/keyboard/adp5589-keys.c +++ b/drivers/input/keyboard/adp5589-keys.c @@ -930,8 +930,6 @@ static int adp5589_keypad_add(struct adp5589_kpad *kpad, unsigned int revid) return error; } - device_init_wakeup(&client->dev, 1); - return 0; }
We should not be configuring the controller as a wakeup source in the driver, but rather rely on I2C core to mark it as such by either instantiating as I2C_CLIENT_WAKEUP or specifying "wakeup-source" device property. Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> --- drivers/input/keyboard/adp5589-keys.c | 2 -- 1 file changed, 2 deletions(-)