| Message ID | 20201123061508.GA1009828@dtor-ws (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | fa248db082270200863d254e0f39bbb29923d6b1 |
| Headers | show |
| Series | Input: soc_button_array - add missing include | expand |
Hi, On 11/23/20 7:15 AM, Dmitry Torokhov wrote: > This fixes the following build errors: > > CC [M] drivers/input/misc/soc_button_array.o > drivers/input/misc/soc_button_array.c:156:4: error: implicit declaration of function 'irq_set_irq_type' [-Werror,-Wimplicit-function-declaration] > irq_set_irq_type(irq, IRQ_TYPE_LEVEL_LOW); > ^ > drivers/input/misc/soc_button_array.c:156:26: error: use of undeclared identifier 'IRQ_TYPE_LEVEL_LOW' > irq_set_irq_type(irq, IRQ_TYPE_LEVEL_LOW); > ^ > 2 errors generated. > > Fixes: 78a5b53e9fb4 ("Input: soc_button_array - work around DSDTs which modify the irqflags") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > drivers/input/misc/soc_button_array.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/input/misc/soc_button_array.c b/drivers/input/misc/soc_button_array.c > index cae1a3fae83a..d14a65683c5e 100644 > --- a/drivers/input/misc/soc_button_array.c > +++ b/drivers/input/misc/soc_button_array.c > @@ -9,6 +9,7 @@ > #include <linux/module.h> > #include <linux/input.h> > #include <linux/init.h> > +#include <linux/irq.h> > #include <linux/kernel.h> > #include <linux/acpi.h> > #include <linux/dmi.h> >
diff --git a/drivers/input/misc/soc_button_array.c b/drivers/input/misc/soc_button_array.c index cae1a3fae83a..d14a65683c5e 100644 --- a/drivers/input/misc/soc_button_array.c +++ b/drivers/input/misc/soc_button_array.c @@ -9,6 +9,7 @@ #include <linux/module.h> #include <linux/input.h> #include <linux/init.h> +#include <linux/irq.h> #include <linux/kernel.h> #include <linux/acpi.h> #include <linux/dmi.h>
This fixes the following build errors: CC [M] drivers/input/misc/soc_button_array.o drivers/input/misc/soc_button_array.c:156:4: error: implicit declaration of function 'irq_set_irq_type' [-Werror,-Wimplicit-function-declaration] irq_set_irq_type(irq, IRQ_TYPE_LEVEL_LOW); ^ drivers/input/misc/soc_button_array.c:156:26: error: use of undeclared identifier 'IRQ_TYPE_LEVEL_LOW' irq_set_irq_type(irq, IRQ_TYPE_LEVEL_LOW); ^ 2 errors generated. Fixes: 78a5b53e9fb4 ("Input: soc_button_array - work around DSDTs which modify the irqflags") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> --- drivers/input/misc/soc_button_array.c | 1 + 1 file changed, 1 insertion(+)