| Message ID | 20201124001802.10094-1-rdunlap@infradead.org (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | fa248db082270200863d254e0f39bbb29923d6b1 |
| Headers | show |
| Series | input: soc_button_array: fix IRQ-related build errors | expand |
Hi Randy, On 11/24/20 1:18 AM, Randy Dunlap wrote: > Fix these new build errors by adding <linux/irq.h>: > > ../drivers/input/misc/soc_button_array.c: In function ‘soc_button_device_create’: > ../drivers/input/misc/soc_button_array.c:156:4: error: implicit declaration of function ‘irq_set_irq_type’; did you mean ‘acpi_dev_get_irq_type’? [-Werror=implicit-function-declaration] > irq_set_irq_type(irq, IRQ_TYPE_LEVEL_LOW); > CC [M] drivers/rtc/rtc-ds1343.o > ../drivers/input/misc/soc_button_array.c:156:26: error: ‘IRQ_TYPE_LEVEL_LOW’ undeclared (first use in this function) > irq_set_irq_type(irq, IRQ_TYPE_LEVEL_LOW); > > Fixes: 78a5b53e9fb4 ("Input: soc_button_array - work around DSDTs which modify the irqflags") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Reported-by: kernel test robot <lkp@intel.com> > Cc: Hans de Goede <hdegoede@redhat.com> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> > Cc: linux-input@vger.kernel.org Thank you for your fix, but Dmitry already send out the same fix yesterday, so your fix is a duplicate. Regards, Hans > --- > drivers/input/misc/soc_button_array.c | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20201123.orig/drivers/input/misc/soc_button_array.c > +++ linux-next-20201123/drivers/input/misc/soc_button_array.c > @@ -9,6 +9,7 @@ > #include <linux/module.h> > #include <linux/input.h> > #include <linux/init.h> > +#include <linux/irq.h> > #include <linux/kernel.h> > #include <linux/acpi.h> > #include <linux/dmi.h> >
--- linux-next-20201123.orig/drivers/input/misc/soc_button_array.c +++ linux-next-20201123/drivers/input/misc/soc_button_array.c @@ -9,6 +9,7 @@ #include <linux/module.h> #include <linux/input.h> #include <linux/init.h> +#include <linux/irq.h> #include <linux/kernel.h> #include <linux/acpi.h> #include <linux/dmi.h>
Fix these new build errors by adding <linux/irq.h>: ../drivers/input/misc/soc_button_array.c: In function ‘soc_button_device_create’: ../drivers/input/misc/soc_button_array.c:156:4: error: implicit declaration of function ‘irq_set_irq_type’; did you mean ‘acpi_dev_get_irq_type’? [-Werror=implicit-function-declaration] irq_set_irq_type(irq, IRQ_TYPE_LEVEL_LOW); CC [M] drivers/rtc/rtc-ds1343.o ../drivers/input/misc/soc_button_array.c:156:26: error: ‘IRQ_TYPE_LEVEL_LOW’ undeclared (first use in this function) irq_set_irq_type(irq, IRQ_TYPE_LEVEL_LOW); Fixes: 78a5b53e9fb4 ("Input: soc_button_array - work around DSDTs which modify the irqflags") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Reported-by: kernel test robot <lkp@intel.com> Cc: Hans de Goede <hdegoede@redhat.com> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> Cc: linux-input@vger.kernel.org --- drivers/input/misc/soc_button_array.c | 1 + 1 file changed, 1 insertion(+)